Skip to content

Commit 29f7c54

Browse files
John Garrygregkh
authored andcommitted
Driver core: platform: Add extra error check in devm_platform_get_irqs_affinity()
The current check of nvec < minvec for nvec returned from platform_irq_count() will not detect a negative error code in nvec. This is because minvec is unsigned, and, as such, nvec is promoted to unsigned in that check, which will make it a huge number (if it contained -EPROBE_DEFER). In practice, an error should not occur in nvec for the only in-tree user, but add a check anyway. Fixes: e15f2fa ("driver core: platform: Add devm_platform_get_irqs_affinity()") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: John Garry <john.garry@huawei.com> Link: https://lore.kernel.org/r/1608561055-231244-1-git-send-email-john.garry@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d0243bb commit 29f7c54

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/base/platform.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,8 @@ int devm_platform_get_irqs_affinity(struct platform_device *dev,
366366
return -ERANGE;
367367

368368
nvec = platform_irq_count(dev);
369+
if (nvec < 0)
370+
return nvec;
369371

370372
if (nvec < minvec)
371373
return -ENOSPC;

0 commit comments

Comments
 (0)