Skip to content

Commit 2a0091f

Browse files
committed
PCI: brcmstb: Sort enums, pcie_offsets[], pcie_cfg_data, .compatible strings
Sort enum pcie_soc_base values. Rename pcie_offsets_bmips_7425[] to pcie_offsets_bcm7425[] to match BCM7425 pcie_soc_base enum, bcm7425_cfg, and "brcm,bcm7425-pcie" .compatible string. Rename pcie_offset_bcm7278[] to pcie_offsets_bcm7278[] to match other "pcie_offsets" names. Rename pcie_offset_bcm7712[] to pcie_offsets_bcm7712[] to match other "pcie_offsets" names. Sort pcie_offsets_*[] by SoC name, move them all together, indent values for easy reading. Sort pcie_cfg_data structs by SoC name. Sort .compatible strings by SoC name. No functional change intended. Link: https://lore.kernel.org/r/20240902205456.227409-1-helgaas@kernel.org Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
1 parent 91e5d15 commit 2a0091f

1 file changed

Lines changed: 45 additions & 45 deletions

File tree

drivers/pci/controller/pcie-brcmstb.c

Lines changed: 45 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -220,11 +220,11 @@ enum {
220220

221221
enum pcie_soc_base {
222222
GENERIC,
223-
BCM7425,
224-
BCM7435,
223+
BCM2711,
225224
BCM4908,
226225
BCM7278,
227-
BCM2711,
226+
BCM7425,
227+
BCM7435,
228228
BCM7712,
229229
};
230230

@@ -1665,26 +1665,34 @@ static void brcm_pcie_remove(struct platform_device *pdev)
16651665
}
16661666

16671667
static const int pcie_offsets[] = {
1668-
[RGR1_SW_INIT_1] = 0x9210,
1669-
[EXT_CFG_INDEX] = 0x9000,
1670-
[EXT_CFG_DATA] = 0x9004,
1671-
[PCIE_HARD_DEBUG] = 0x4204,
1672-
[PCIE_INTR2_CPU_BASE] = 0x4300,
1668+
[RGR1_SW_INIT_1] = 0x9210,
1669+
[EXT_CFG_INDEX] = 0x9000,
1670+
[EXT_CFG_DATA] = 0x9004,
1671+
[PCIE_HARD_DEBUG] = 0x4204,
1672+
[PCIE_INTR2_CPU_BASE] = 0x4300,
1673+
};
1674+
1675+
static const int pcie_offsets_bcm7278[] = {
1676+
[RGR1_SW_INIT_1] = 0xc010,
1677+
[EXT_CFG_INDEX] = 0x9000,
1678+
[EXT_CFG_DATA] = 0x9004,
1679+
[PCIE_HARD_DEBUG] = 0x4204,
1680+
[PCIE_INTR2_CPU_BASE] = 0x4300,
16731681
};
16741682

1675-
static const int pcie_offsets_bmips_7425[] = {
1676-
[RGR1_SW_INIT_1] = 0x8010,
1677-
[EXT_CFG_INDEX] = 0x8300,
1678-
[EXT_CFG_DATA] = 0x8304,
1679-
[PCIE_HARD_DEBUG] = 0x4204,
1680-
[PCIE_INTR2_CPU_BASE] = 0x4300,
1683+
static const int pcie_offsets_bcm7425[] = {
1684+
[RGR1_SW_INIT_1] = 0x8010,
1685+
[EXT_CFG_INDEX] = 0x8300,
1686+
[EXT_CFG_DATA] = 0x8304,
1687+
[PCIE_HARD_DEBUG] = 0x4204,
1688+
[PCIE_INTR2_CPU_BASE] = 0x4300,
16811689
};
16821690

1683-
static const int pcie_offset_bcm7712[] = {
1684-
[EXT_CFG_INDEX] = 0x9000,
1685-
[EXT_CFG_DATA] = 0x9004,
1686-
[PCIE_HARD_DEBUG] = 0x4304,
1687-
[PCIE_INTR2_CPU_BASE] = 0x4400,
1691+
static const int pcie_offsets_bcm7712[] = {
1692+
[EXT_CFG_INDEX] = 0x9000,
1693+
[EXT_CFG_DATA] = 0x9004,
1694+
[PCIE_HARD_DEBUG] = 0x4304,
1695+
[PCIE_INTR2_CPU_BASE] = 0x4400,
16881696
};
16891697

16901698
static const struct pcie_cfg_data generic_cfg = {
@@ -1695,17 +1703,9 @@ static const struct pcie_cfg_data generic_cfg = {
16951703
.num_inbound_wins = 3,
16961704
};
16971705

1698-
static const struct pcie_cfg_data bcm7425_cfg = {
1699-
.offsets = pcie_offsets_bmips_7425,
1700-
.soc_base = BCM7425,
1701-
.perst_set = brcm_pcie_perst_set_generic,
1702-
.bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_generic,
1703-
.num_inbound_wins = 3,
1704-
};
1705-
1706-
static const struct pcie_cfg_data bcm7435_cfg = {
1706+
static const struct pcie_cfg_data bcm2711_cfg = {
17071707
.offsets = pcie_offsets,
1708-
.soc_base = BCM7435,
1708+
.soc_base = BCM2711,
17091709
.perst_set = brcm_pcie_perst_set_generic,
17101710
.bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_generic,
17111711
.num_inbound_wins = 3,
@@ -1719,32 +1719,32 @@ static const struct pcie_cfg_data bcm4908_cfg = {
17191719
.num_inbound_wins = 3,
17201720
};
17211721

1722-
static const int pcie_offset_bcm7278[] = {
1723-
[RGR1_SW_INIT_1] = 0xc010,
1724-
[EXT_CFG_INDEX] = 0x9000,
1725-
[EXT_CFG_DATA] = 0x9004,
1726-
[PCIE_HARD_DEBUG] = 0x4204,
1727-
[PCIE_INTR2_CPU_BASE] = 0x4300,
1728-
};
1729-
17301722
static const struct pcie_cfg_data bcm7278_cfg = {
1731-
.offsets = pcie_offset_bcm7278,
1723+
.offsets = pcie_offsets_bcm7278,
17321724
.soc_base = BCM7278,
17331725
.perst_set = brcm_pcie_perst_set_7278,
17341726
.bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_7278,
17351727
.num_inbound_wins = 3,
17361728
};
17371729

1738-
static const struct pcie_cfg_data bcm2711_cfg = {
1730+
static const struct pcie_cfg_data bcm7425_cfg = {
1731+
.offsets = pcie_offsets_bcm7425,
1732+
.soc_base = BCM7425,
1733+
.perst_set = brcm_pcie_perst_set_generic,
1734+
.bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_generic,
1735+
.num_inbound_wins = 3,
1736+
};
1737+
1738+
static const struct pcie_cfg_data bcm7435_cfg = {
17391739
.offsets = pcie_offsets,
1740-
.soc_base = BCM2711,
1740+
.soc_base = BCM7435,
17411741
.perst_set = brcm_pcie_perst_set_generic,
17421742
.bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_generic,
17431743
.num_inbound_wins = 3,
17441744
};
17451745

17461746
static const struct pcie_cfg_data bcm7216_cfg = {
1747-
.offsets = pcie_offset_bcm7278,
1747+
.offsets = pcie_offsets_bcm7278,
17481748
.soc_base = BCM7278,
17491749
.perst_set = brcm_pcie_perst_set_7278,
17501750
.bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_7278,
@@ -1753,7 +1753,7 @@ static const struct pcie_cfg_data bcm7216_cfg = {
17531753
};
17541754

17551755
static const struct pcie_cfg_data bcm7712_cfg = {
1756-
.offsets = pcie_offset_bcm7712,
1756+
.offsets = pcie_offsets_bcm7712,
17571757
.perst_set = brcm_pcie_perst_set_7278,
17581758
.bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_generic,
17591759
.soc_base = BCM7712,
@@ -1764,11 +1764,11 @@ static const struct of_device_id brcm_pcie_match[] = {
17641764
{ .compatible = "brcm,bcm2711-pcie", .data = &bcm2711_cfg },
17651765
{ .compatible = "brcm,bcm4908-pcie", .data = &bcm4908_cfg },
17661766
{ .compatible = "brcm,bcm7211-pcie", .data = &generic_cfg },
1767-
{ .compatible = "brcm,bcm7278-pcie", .data = &bcm7278_cfg },
17681767
{ .compatible = "brcm,bcm7216-pcie", .data = &bcm7216_cfg },
1769-
{ .compatible = "brcm,bcm7445-pcie", .data = &generic_cfg },
1770-
{ .compatible = "brcm,bcm7435-pcie", .data = &bcm7435_cfg },
1768+
{ .compatible = "brcm,bcm7278-pcie", .data = &bcm7278_cfg },
17711769
{ .compatible = "brcm,bcm7425-pcie", .data = &bcm7425_cfg },
1770+
{ .compatible = "brcm,bcm7435-pcie", .data = &bcm7435_cfg },
1771+
{ .compatible = "brcm,bcm7445-pcie", .data = &generic_cfg },
17721772
{ .compatible = "brcm,bcm7712-pcie", .data = &bcm7712_cfg },
17731773
{},
17741774
};

0 commit comments

Comments
 (0)