Skip to content

Commit 2a330f1

Browse files
avri-altman-sndkmartinkpetersen
authored andcommitted
scsi: ufs: core: Remove redundant host_lock calls around UTRLCLR.
There is no need to serialize single read/write calls to the host controller registers. Remove the redundant host_lock calls that protect access to the request list cLear register: UTRLCLR. Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Avri Altman <avri.altman@wdc.com> Link: https://lore.kernel.org/r/20241024075033.562562-4-avri.altman@wdc.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 5824e18 commit 2a330f1

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

drivers/ufs/core/ufshcd.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3062,7 +3062,6 @@ bool ufshcd_cmd_inflight(struct scsi_cmnd *cmd)
30623062
static int ufshcd_clear_cmd(struct ufs_hba *hba, u32 task_tag)
30633063
{
30643064
u32 mask;
3065-
unsigned long flags;
30663065
int err;
30673066

30683067
if (hba->mcq_enabled) {
@@ -3082,9 +3081,7 @@ static int ufshcd_clear_cmd(struct ufs_hba *hba, u32 task_tag)
30823081
mask = 1U << task_tag;
30833082

30843083
/* clear outstanding transaction before retry */
3085-
spin_lock_irqsave(hba->host->host_lock, flags);
30863084
ufshcd_utrl_clear(hba, mask);
3087-
spin_unlock_irqrestore(hba->host->host_lock, flags);
30883085

30893086
/*
30903087
* wait for h/w to clear corresponding bit in door-bell.

0 commit comments

Comments
 (0)