Skip to content

Commit 2a673fb

Browse files
mwajdeczrodrigovivi
authored andcommitted
drm/xe/configfs: Fix 'parameter name omitted' errors
On some configs and old compilers we can get following build errors: ../drivers/gpu/drm/xe/xe_configfs.h: In function 'xe_configfs_get_ctx_restore_mid_bb': ../drivers/gpu/drm/xe/xe_configfs.h:40:76: error: parameter name omitted static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev, enum xe_engine_class, ^~~~~~~~~~~~~~~~~~~~ ../drivers/gpu/drm/xe/xe_configfs.h: In function 'xe_configfs_get_ctx_restore_post_bb': ../drivers/gpu/drm/xe/xe_configfs.h:42:77: error: parameter name omitted static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev, enum xe_engine_class, ^~~~~~~~~~~~~~~~~~~~ when trying to define our configfs stub functions. Fix that. Fixes: 7a4756b ("drm/xe/lrc: Allow to add user commands mid context switch") Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Reviewed-by: Shuicheng Lin <shuicheng.lin@intel.com> Link: https://patch.msgid.link/20260203193745.576-1-michal.wajdeczko@intel.com (cherry picked from commit f59cde8) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent bf7172c commit 2a673fb

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

drivers/gpu/drm/xe/xe_configfs.h

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,11 @@ bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev);
2121
bool xe_configfs_media_gt_allowed(struct pci_dev *pdev);
2222
u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev);
2323
bool xe_configfs_get_psmi_enabled(struct pci_dev *pdev);
24-
u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev, enum xe_engine_class,
24+
u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev,
25+
enum xe_engine_class class,
2526
const u32 **cs);
26-
u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev, enum xe_engine_class,
27+
u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev,
28+
enum xe_engine_class class,
2729
const u32 **cs);
2830
#ifdef CONFIG_PCI_IOV
2931
unsigned int xe_configfs_get_max_vfs(struct pci_dev *pdev);
@@ -37,9 +39,11 @@ static inline bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev) { return
3739
static inline bool xe_configfs_media_gt_allowed(struct pci_dev *pdev) { return true; }
3840
static inline u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev) { return U64_MAX; }
3941
static inline bool xe_configfs_get_psmi_enabled(struct pci_dev *pdev) { return false; }
40-
static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev, enum xe_engine_class,
42+
static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev,
43+
enum xe_engine_class class,
4144
const u32 **cs) { return 0; }
42-
static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev, enum xe_engine_class,
45+
static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev,
46+
enum xe_engine_class class,
4347
const u32 **cs) { return 0; }
4448
static inline unsigned int xe_configfs_get_max_vfs(struct pci_dev *pdev) { return UINT_MAX; }
4549
#endif

0 commit comments

Comments
 (0)