Skip to content

Commit 2a6a491

Browse files
Sung Joon Kimalexdeucher
authored andcommitted
drm/amd/display: Fix HDMI framepack 3D test issue
[why] Bandwidth validation failure on framepack tests. Need to double pixel clock when 3D format is framepack. Also for HDMI displays, we need to keep the ITC flag to 1 by default. [how] Double the pixel clock when using framepack 3D format. Set hdmi ITC bit to 1. Reviewed-by: Charlene Liu <charlene.liu@amd.com> Acked-by: Roman Li <roman.li@amd.com> Signed-off-by: Sung Joon Kim <sungkim@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent da2d16f commit 2a6a491

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/gpu/drm/amd/display/dc/core/dc_resource.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4229,7 +4229,7 @@ static void set_avi_info_frame(
42294229
switch (stream->content_type) {
42304230
case DISPLAY_CONTENT_TYPE_NO_DATA:
42314231
hdmi_info.bits.CN0_CN1 = 0;
4232-
hdmi_info.bits.ITC = 0;
4232+
hdmi_info.bits.ITC = 1;
42334233
break;
42344234
case DISPLAY_CONTENT_TYPE_GRAPHICS:
42354235
hdmi_info.bits.CN0_CN1 = 0;

drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -571,6 +571,8 @@ static void populate_dml_timing_cfg_from_stream_state(struct dml_timing_cfg_st *
571571
out->RefreshRate[location] = ((in->timing.pix_clk_100hz * 100) / in->timing.h_total) / in->timing.v_total;
572572
out->VFrontPorch[location] = in->timing.v_front_porch;
573573
out->PixelClock[location] = in->timing.pix_clk_100hz / 10000.00;
574+
if (in->timing.timing_3d_format == TIMING_3D_FORMAT_HW_FRAME_PACKING)
575+
out->PixelClock[location] *= 2;
574576
out->HTotal[location] = in->timing.h_total;
575577
out->VTotal[location] = in->timing.v_total;
576578
out->Interlace[location] = in->timing.flags.INTERLACE;

0 commit comments

Comments
 (0)