Skip to content

Commit 2a8e41a

Browse files
cpackham-atlnzgroeck
authored andcommitted
hwmon: (adt7475) Use device_property APIs when configuring polarity
On DT unaware platforms of_property_read_u32_array() returns -ENOSYS which wasn't handled by the code treating adi,pwm-active-state as optional. Update the code to use device_property_read_u32_array() which deals gracefully with DT unaware platforms. Fixes: 86da28e ("hwmon: (adt7475) Add support for inverting pwm output") Reported-by: Mariusz Białończyk <manio@skyboo.net> Link: https://lore.kernel.org/linux-hwmon/52e26a67-9131-2dc0-40cb-db5c07370027@alliedtelesis.co.nz/T/#mdd0505801e0a4e72340de009a47c0fca4f771ed3 Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Link: https://lore.kernel.org/r/20230418233656.869055-2-chris.packham@alliedtelesis.co.nz Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 19692f1 commit 2a8e41a

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/hwmon/adt7475.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1604,9 +1604,9 @@ static int adt7475_set_pwm_polarity(struct i2c_client *client)
16041604
int ret, i;
16051605
u8 val;
16061606

1607-
ret = of_property_read_u32_array(client->dev.of_node,
1608-
"adi,pwm-active-state", states,
1609-
ARRAY_SIZE(states));
1607+
ret = device_property_read_u32_array(&client->dev,
1608+
"adi,pwm-active-state", states,
1609+
ARRAY_SIZE(states));
16101610
if (ret)
16111611
return ret;
16121612

0 commit comments

Comments
 (0)