Skip to content

Commit 2ab867a

Browse files
mchehabJonathan Corbet
authored andcommitted
scripts/kernel-doc.py: move modulename to man class
Only man output requires a modulename. Move its definition to the man class. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Jonathan Corbet <corbet@lwn.net> Link: https://lore.kernel.org/r/583085e3885b0075d16ef9961b4f2ad870f30a55.1744106242.git.mchehab+huawei@kernel.org
1 parent 78ea748 commit 2ab867a

4 files changed

Lines changed: 11 additions & 22 deletions

File tree

scripts/kernel-doc.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ def main():
186186
help="Enable debug messages")
187187

188188
parser.add_argument("-M", "-modulename", "--modulename",
189+
default="Kernel API",
189190
help="Allow setting a module name at the output.")
190191

191192
parser.add_argument("-l", "-enable-lineno", "--enable_lineno",
@@ -273,7 +274,7 @@ def main():
273274
logger.addHandler(handler)
274275

275276
if args.man:
276-
out_style = ManFormat()
277+
out_style = ManFormat(modulename=args.modulename)
277278
elif args.none:
278279
out_style = None
279280
else:
@@ -282,8 +283,7 @@ def main():
282283
kfiles = KernelFiles(verbose=args.verbose,
283284
out_style=out_style, werror=args.werror,
284285
wreturn=args.wreturn, wshort_desc=args.wshort_desc,
285-
wcontents_before_sections=args.wcontents_before_sections,
286-
modulename=args.modulename)
286+
wcontents_before_sections=args.wcontents_before_sections)
287287

288288
kfiles.parse(args.files, export_file=args.export_file)
289289

scripts/lib/kdoc/kdoc_files.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -126,17 +126,14 @@ def file_not_found_cb(self, fname):
126126
def __init__(self, verbose=False, out_style=None,
127127
werror=False, wreturn=False, wshort_desc=False,
128128
wcontents_before_sections=False,
129-
logger=None, modulename=None):
129+
logger=None):
130130
"""
131131
Initialize startup variables and parse all files
132132
"""
133133

134134
if not verbose:
135135
verbose = bool(os.environ.get("KBUILD_VERBOSE", 0))
136136

137-
if not modulename:
138-
modulename = "Kernel API"
139-
140137
if out_style is None:
141138
out_style = OutputFormat()
142139

@@ -168,7 +165,6 @@ def __init__(self, verbose=False, out_style=None,
168165
self.config.wreturn = wreturn
169166
self.config.wshort_desc = wshort_desc
170167
self.config.wcontents_before_sections = wcontents_before_sections
171-
self.config.modulename = modulename
172168

173169
self.config.function_table = set()
174170
self.config.source_map = {}

scripts/lib/kdoc/kdoc_output.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ class ManFormat(OutputFormat):
586586
)
587587
blankline = ""
588588

589-
def __init__(self):
589+
def __init__(self, modulename):
590590
"""
591591
Creates class variables.
592592
@@ -595,6 +595,7 @@ def __init__(self):
595595
"""
596596

597597
super().__init__()
598+
self.modulename = modulename
598599

599600
dt = datetime.now()
600601
if os.environ.get("KBUILD_BUILD_TIMESTAMP", None):
@@ -626,14 +627,13 @@ def output_highlight(self, block):
626627
self.data += line + "\n"
627628

628629
def out_doc(self, fname, name, args):
629-
module = args.get('module')
630630
sectionlist = args.get('sectionlist', [])
631631
sections = args.get('sections', {})
632632

633633
if not self.check_doc(name, args):
634634
return
635635

636-
self.data += f'.TH "{module}" 9 "{module}" "{self.man_date}" "API Manual" LINUX' + "\n"
636+
self.data += f'.TH "{self.modulename}" 9 "{self.modulename}" "{self.man_date}" "API Manual" LINUX' + "\n"
637637

638638
for section in sectionlist:
639639
self.data += f'.SH "{section}"' + "\n"
@@ -697,7 +697,7 @@ def out_enum(self, fname, name, args):
697697
sectionlist = args.get('sectionlist', [])
698698
sections = args.get('sections', {})
699699

700-
self.data += f'.TH "{args["module"]}" 9 "enum {args["enum"]}" "{self.man_date}" "API Manual" LINUX' + "\n"
700+
self.data += f'.TH "{self.modulename}" 9 "enum {args["enum"]}" "{self.man_date}" "API Manual" LINUX' + "\n"
701701

702702
self.data += ".SH NAME\n"
703703
self.data += f"enum {args['enum']} \\- {args['purpose']}\n"
@@ -727,7 +727,7 @@ def out_enum(self, fname, name, args):
727727
self.output_highlight(sections[section])
728728

729729
def out_typedef(self, fname, name, args):
730-
module = args.get('module')
730+
module = self.modulename
731731
typedef = args.get('typedef')
732732
purpose = args.get('purpose')
733733
sectionlist = args.get('sectionlist', [])
@@ -743,7 +743,7 @@ def out_typedef(self, fname, name, args):
743743
self.output_highlight(sections.get(section))
744744

745745
def out_struct(self, fname, name, args):
746-
module = args.get('module')
746+
module = self.modulename
747747
struct_type = args.get('type')
748748
struct_name = args.get('struct')
749749
purpose = args.get('purpose')

scripts/lib/kdoc/kdoc_parser.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -791,7 +791,6 @@ def dump_struct(self, ln, proto):
791791

792792
self.output_declaration(decl_type, declaration_name,
793793
struct=declaration_name,
794-
module=self.entry.modulename,
795794
definition=declaration,
796795
parameterlist=self.entry.parameterlist,
797796
parameterdescs=self.entry.parameterdescs,
@@ -869,7 +868,6 @@ def dump_enum(self, ln, proto):
869868

870869
self.output_declaration('enum', declaration_name,
871870
enum=declaration_name,
872-
module=self.config.modulename,
873871
parameterlist=self.entry.parameterlist,
874872
parameterdescs=self.entry.parameterdescs,
875873
parameterdesc_start_lines=self.entry.parameterdesc_start_lines,
@@ -1040,7 +1038,6 @@ def dump_function(self, ln, prototype):
10401038
self.output_declaration(decl_type, declaration_name,
10411039
function=declaration_name,
10421040
typedef=True,
1043-
module=self.config.modulename,
10441041
functiontype=return_type,
10451042
parameterlist=self.entry.parameterlist,
10461043
parameterdescs=self.entry.parameterdescs,
@@ -1055,7 +1052,6 @@ def dump_function(self, ln, prototype):
10551052
self.output_declaration(decl_type, declaration_name,
10561053
function=declaration_name,
10571054
typedef=False,
1058-
module=self.config.modulename,
10591055
functiontype=return_type,
10601056
parameterlist=self.entry.parameterlist,
10611057
parameterdescs=self.entry.parameterdescs,
@@ -1102,7 +1098,6 @@ def dump_typedef(self, ln, proto):
11021098
self.output_declaration(decl_type, declaration_name,
11031099
function=declaration_name,
11041100
typedef=True,
1105-
module=self.entry.modulename,
11061101
functiontype=return_type,
11071102
parameterlist=self.entry.parameterlist,
11081103
parameterdescs=self.entry.parameterdescs,
@@ -1130,7 +1125,6 @@ def dump_typedef(self, ln, proto):
11301125

11311126
self.output_declaration('typedef', declaration_name,
11321127
typedef=declaration_name,
1133-
module=self.entry.modulename,
11341128
sectionlist=self.entry.sectionlist,
11351129
sections=self.entry.sections,
11361130
section_start_lines=self.entry.section_start_lines,
@@ -1619,8 +1613,7 @@ def process_docblock(self, ln, line):
16191613
self.output_declaration("doc", self.entry.identifier,
16201614
sectionlist=self.entry.sectionlist,
16211615
sections=self.entry.sections,
1622-
section_start_lines=self.entry.section_start_lines,
1623-
module=self.config.modulename)
1616+
section_start_lines=self.entry.section_start_lines)
16241617
self.reset_state(ln)
16251618

16261619
elif doc_content.search(line):

0 commit comments

Comments
 (0)