Skip to content

Commit 2b5160b

Browse files
Thadeu Lima de Souza Cascardocminyard
authored andcommitted
ipmi: bail out if init_srcu_struct fails
In case, init_srcu_struct fails (because of memory allocation failure), we might proceed with the driver initialization despite srcu_struct not being entirely initialized. Fixes: 913a89f ("ipmi: Don't initialize anything in the core until something uses it") Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> Cc: Corey Minyard <cminyard@mvista.com> Cc: stable@vger.kernel.org Message-Id: <20211217154410.1228673-1-cascardo@canonical.com> Signed-off-by: Corey Minyard <cminyard@mvista.com>
1 parent 34f35f8 commit 2b5160b

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/char/ipmi/ipmi_msghandler.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5392,7 +5392,9 @@ static int ipmi_init_msghandler(void)
53925392
if (initialized)
53935393
goto out;
53945394

5395-
init_srcu_struct(&ipmi_interfaces_srcu);
5395+
rv = init_srcu_struct(&ipmi_interfaces_srcu);
5396+
if (rv)
5397+
goto out;
53965398

53975399
timer_setup(&ipmi_timer, ipmi_timeout, 0);
53985400
mod_timer(&ipmi_timer, jiffies + IPMI_TIMEOUT_JIFFIES);

0 commit comments

Comments
 (0)