Skip to content

Commit 2b534e9

Browse files
committed
Merge tag 'drm-msm-next-2021-12-26' of ssh://gitlab.freedesktop.org/drm/msm into drm-next
* dpu plane state cleanup in prep for multirect * dpu debugfs cleanup (and moving things to atomic_print_state) in prep for multirect * dp support for sc7280 * struct_mutex removal * include more GMU state in gpu devcore dumps * add support for a506 * remove old eDP sub-driver (never was used in any upstream supported devices and modern things with eDP will use DP sub-driver instead) * debugfs to disable hw gpu hang detect for (igt tests) * debugfs for dumping display hw state * and the usual assortment of cleanup and bug fixes There still seems to be a timing issue with dpu, showing up on sc7180 devices, after the bridge probe-order change. Ie. things work great if loglevel is high enough (or enough debug options are enabled, etc). We'll continue to debug this in the new year. Signed-off-by: Dave Airlie <airlied@redhat.com> From: Rob Clark <robdclark@gmail.com> Link: https://patchwork.freedesktop.org/patch/msgid/CAF6AEGs+vwr0nkwgYzuYAsCoHtypWpWav+yVvLZGsEJy8tJ56A@mail.gmail.com
2 parents 040bf2a + 6ed9528 commit 2b534e9

82 files changed

Lines changed: 1431 additions & 3903 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.mailmap

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,12 @@
1010
# Please keep this list dictionary sorted.
1111
#
1212
Aaron Durbin <adurbin@google.com>
13+
Abhinav Kumar <quic_abhinavk@quicinc.com> <abhinavk@codeaurora.org>
1314
Adam Oldham <oldhamca@gmail.com>
1415
Adam Radford <aradford@gmail.com>
1516
Adriana Reus <adi.reus@gmail.com> <adriana.reus@intel.com>
1617
Adrian Bunk <bunk@stusta.de>
18+
Akhil P Oommen <quic_akhilpo@quicinc.com> <akhilpo@codeaurora.org>
1719
Alan Cox <alan@lxorguk.ukuu.org.uk>
1820
Alan Cox <root@hraefn.swansea.linux.org.uk>
1921
Aleksandar Markovic <aleksandar.markovic@mips.com> <aleksandar.markovic@imgtec.com>
@@ -172,6 +174,7 @@ Jeff Layton <jlayton@kernel.org> <jlayton@redhat.com>
172174
Jens Axboe <axboe@suse.de>
173175
Jens Osterkamp <Jens.Osterkamp@de.ibm.com>
174176
Jernej Skrabec <jernej.skrabec@gmail.com> <jernej.skrabec@siol.net>
177+
Jessica Zhang <quic_jesszhan@quicinc.com> <jesszhan@codeaurora.org>
175178
Jiri Slaby <jirislaby@kernel.org> <jirislaby@gmail.com>
176179
Jiri Slaby <jirislaby@kernel.org> <jslaby@novell.com>
177180
Jiri Slaby <jirislaby@kernel.org> <jslaby@suse.com>
@@ -191,6 +194,7 @@ Juha Yrjola <at solidboot.com>
191194
Juha Yrjola <juha.yrjola@nokia.com>
192195
Juha Yrjola <juha.yrjola@solidboot.com>
193196
Julien Thierry <julien.thierry.kdev@gmail.com> <julien.thierry@arm.com>
197+
Kalyan Thota <quic_kalyant@quicinc.com> <kalyan_t@codeaurora.org>
194198
Kay Sievers <kay.sievers@vrfy.org>
195199
Kees Cook <keescook@chromium.org> <kees.cook@canonical.com>
196200
Kees Cook <keescook@chromium.org> <keescook@google.com>
@@ -202,9 +206,11 @@ Kenneth W Chen <kenneth.w.chen@intel.com>
202206
Konstantin Khlebnikov <koct9i@gmail.com> <khlebnikov@yandex-team.ru>
203207
Konstantin Khlebnikov <koct9i@gmail.com> <k.khlebnikov@samsung.com>
204208
Koushik <raghavendra.koushik@neterion.com>
209+
Krishna Manikandan <quic_mkrishn@quicinc.com> <mkrishn@codeaurora.org>
205210
Krzysztof Kozlowski <krzk@kernel.org> <k.kozlowski.k@gmail.com>
206211
Krzysztof Kozlowski <krzk@kernel.org> <k.kozlowski@samsung.com>
207212
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
213+
Kuogee Hsieh <quic_khsieh@quicinc.com> <khsieh@codeaurora.org>
208214
Leonardo Bras <leobras.c@gmail.com> <leonardo@linux.ibm.com>
209215
Leonid I Ananiev <leonid.i.ananiev@intel.com>
210216
Leon Romanovsky <leon@kernel.org> <leon@leon.nu>
@@ -311,6 +317,7 @@ Qais Yousef <qsyousef@gmail.com> <qais.yousef@imgtec.com>
311317
Quentin Monnet <quentin@isovalent.com> <quentin.monnet@netronome.com>
312318
Quentin Perret <qperret@qperret.net> <quentin.perret@arm.com>
313319
Rafael J. Wysocki <rjw@rjwysocki.net> <rjw@sisk.pl>
320+
Rajeev Nandan <quic_rajeevny@quicinc.com> <rajeevny@codeaurora.org>
314321
Rajesh Shah <rajesh.shah@intel.com>
315322
Ralf Baechle <ralf@linux-mips.org>
316323
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
@@ -325,6 +332,7 @@ Rui Saraiva <rmps@joel.ist.utl.pt>
325332
Sachin P Sant <ssant@in.ibm.com>
326333
Sakari Ailus <sakari.ailus@linux.intel.com> <sakari.ailus@iki.fi>
327334
Sam Ravnborg <sam@mars.ravnborg.org>
335+
Sankeerth Billakanti <quic_sbillaka@quicinc.com> <sbillaka@codeaurora.org>
328336
Santosh Shilimkar <santosh.shilimkar@oracle.org>
329337
Santosh Shilimkar <ssantosh@kernel.org>
330338
Sarangdhar Joshi <spjoshi@codeaurora.org>

Documentation/devicetree/bindings/display/msm/dp-controller.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ properties:
1717
compatible:
1818
enum:
1919
- qcom,sc7180-dp
20+
- qcom,sc7280-dp
21+
- qcom,sc7280-edp
2022
- qcom,sc8180x-dp
2123
- qcom,sc8180x-edp
2224

Documentation/devicetree/bindings/display/msm/edp.txt

Lines changed: 0 additions & 56 deletions
This file was deleted.

MAINTAINERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6050,6 +6050,7 @@ F: drivers/gpu/drm/tiny/mi0283qt.c
60506050
DRM DRIVER FOR MSM ADRENO GPU
60516051
M: Rob Clark <robdclark@gmail.com>
60526052
M: Sean Paul <sean@poorly.run>
6053+
R: Abhinav Kumar <quic_abhinavk@quicinc.com>
60536054
L: linux-arm-msm@vger.kernel.org
60546055
L: dri-devel@lists.freedesktop.org
60556056
L: freedreno@lists.freedesktop.org

drivers/gpu/drm/msm/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ config DRM_MSM_HDMI_HDCP
6565
config DRM_MSM_DP
6666
bool "Enable DisplayPort support in MSM DRM driver"
6767
depends on DRM_MSM
68+
select RATIONAL
6869
default y
6970
help
7071
Compile in support for DP driver in MSM DRM driver. DP external

drivers/gpu/drm/msm/Makefile

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,14 @@ msm-y := \
1919
hdmi/hdmi.o \
2020
hdmi/hdmi_audio.o \
2121
hdmi/hdmi_bridge.o \
22-
hdmi/hdmi_connector.o \
22+
hdmi/hdmi_hpd.o \
2323
hdmi/hdmi_i2c.o \
2424
hdmi/hdmi_phy.o \
2525
hdmi/hdmi_phy_8960.o \
2626
hdmi/hdmi_phy_8996.o \
2727
hdmi/hdmi_phy_8x60.o \
2828
hdmi/hdmi_phy_8x74.o \
2929
hdmi/hdmi_pll_8960.o \
30-
edp/edp.o \
31-
edp/edp_aux.o \
32-
edp/edp_bridge.o \
33-
edp/edp_connector.o \
34-
edp/edp_ctrl.o \
35-
edp/edp_phy.o \
3630
disp/mdp_format.o \
3731
disp/mdp_kms.o \
3832
disp/mdp4/mdp4_crtc.o \

drivers/gpu/drm/msm/adreno/a2xx_gpu.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ static bool a2xx_idle(struct msm_gpu *gpu);
1212

1313
static void a2xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit)
1414
{
15-
struct msm_drm_private *priv = gpu->dev->dev_private;
1615
struct msm_ringbuffer *ring = submit->ring;
1716
unsigned int i;
1817

@@ -23,7 +22,7 @@ static void a2xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit)
2322
break;
2423
case MSM_SUBMIT_CMD_CTX_RESTORE_BUF:
2524
/* ignore if there has not been a ctx switch: */
26-
if (priv->lastctx == submit->queue->ctx)
25+
if (gpu->cur_ctx_seqno == submit->queue->ctx->seqno)
2726
break;
2827
fallthrough;
2928
case MSM_SUBMIT_CMD_BUF:

drivers/gpu/drm/msm/adreno/a3xx_gpu.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ static bool a3xx_idle(struct msm_gpu *gpu);
3030

3131
static void a3xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit)
3232
{
33-
struct msm_drm_private *priv = gpu->dev->dev_private;
3433
struct msm_ringbuffer *ring = submit->ring;
3534
unsigned int i;
3635

@@ -41,7 +40,7 @@ static void a3xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit)
4140
break;
4241
case MSM_SUBMIT_CMD_CTX_RESTORE_BUF:
4342
/* ignore if there has not been a ctx switch: */
44-
if (priv->lastctx == submit->queue->ctx)
43+
if (gpu->cur_ctx_seqno == submit->queue->ctx->seqno)
4544
break;
4645
fallthrough;
4746
case MSM_SUBMIT_CMD_BUF:

drivers/gpu/drm/msm/adreno/a4xx_gpu.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ static bool a4xx_idle(struct msm_gpu *gpu);
2424

2525
static void a4xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit)
2626
{
27-
struct msm_drm_private *priv = gpu->dev->dev_private;
2827
struct msm_ringbuffer *ring = submit->ring;
2928
unsigned int i;
3029

@@ -35,7 +34,7 @@ static void a4xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit)
3534
break;
3635
case MSM_SUBMIT_CMD_CTX_RESTORE_BUF:
3736
/* ignore if there has not been a ctx switch: */
38-
if (priv->lastctx == submit->queue->ctx)
37+
if (gpu->cur_ctx_seqno == submit->queue->ctx->seqno)
3938
break;
4039
fallthrough;
4140
case MSM_SUBMIT_CMD_BUF:

drivers/gpu/drm/msm/adreno/a5xx_debugfs.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ reset_set(void *data, u64 val)
107107
* try to reset an active GPU.
108108
*/
109109

110-
mutex_lock(&dev->struct_mutex);
110+
mutex_lock(&gpu->lock);
111111

112112
release_firmware(adreno_gpu->fw[ADRENO_FW_PM4]);
113113
adreno_gpu->fw[ADRENO_FW_PM4] = NULL;
@@ -133,7 +133,7 @@ reset_set(void *data, u64 val)
133133
gpu->funcs->recover(gpu);
134134

135135
pm_runtime_put_sync(&gpu->pdev->dev);
136-
mutex_unlock(&dev->struct_mutex);
136+
mutex_unlock(&gpu->lock);
137137

138138
return 0;
139139
}

0 commit comments

Comments
 (0)