Skip to content

Commit 2b8e30b

Browse files
tititiou36thierryreding
authored andcommitted
pwm: clk: Use the devm_clk_get_prepared() helper function
Use the devm_clk_get_prepared() helper function instead of hand-writing it. It saves some line of codes. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
1 parent ac9a786 commit 2b8e30b

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

drivers/pwm/pwm-clk.c

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ static int pwm_clk_probe(struct platform_device *pdev)
8989
if (!pcchip)
9090
return -ENOMEM;
9191

92-
pcchip->clk = devm_clk_get(&pdev->dev, NULL);
92+
pcchip->clk = devm_clk_get_prepared(&pdev->dev, NULL);
9393
if (IS_ERR(pcchip->clk))
9494
return dev_err_probe(&pdev->dev, PTR_ERR(pcchip->clk),
9595
"Failed to get clock\n");
@@ -98,15 +98,9 @@ static int pwm_clk_probe(struct platform_device *pdev)
9898
pcchip->chip.ops = &pwm_clk_ops;
9999
pcchip->chip.npwm = 1;
100100

101-
ret = clk_prepare(pcchip->clk);
102-
if (ret < 0)
103-
return dev_err_probe(&pdev->dev, ret, "Failed to prepare clock\n");
104-
105101
ret = pwmchip_add(&pcchip->chip);
106-
if (ret < 0) {
107-
clk_unprepare(pcchip->clk);
102+
if (ret < 0)
108103
return dev_err_probe(&pdev->dev, ret, "Failed to add pwm chip\n");
109-
}
110104

111105
platform_set_drvdata(pdev, pcchip);
112106
return 0;
@@ -120,8 +114,6 @@ static void pwm_clk_remove(struct platform_device *pdev)
120114

121115
if (pcchip->clk_enabled)
122116
clk_disable(pcchip->clk);
123-
124-
clk_unprepare(pcchip->clk);
125117
}
126118

127119
static const struct of_device_id pwm_clk_dt_ids[] = {

0 commit comments

Comments
 (0)