Skip to content

Commit 2bd3059

Browse files
Andrei Simionclaudiubeznea
Andrei Simion
authored and
claudiubeznea
committed
ARM: dts: microchip: Rename LED sub nodes name
dtbs_check warnings: leds: 'd[0-9]', 'ds[0-9]' do not match any of the regexes : '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' leds: 'red', 'green', 'blue' do not match any of regexes : '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' Rename the led sub nodes according to devicetree specification and leds-gpio.yaml and for aks-cdu add label property and use the old node name as value to stay stable and avoid breaking the userspace applications that depend on those paths. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Andrei Simion <andrei.simion@microchip.com> Link: https://lore.kernel.org/r/20241002123010.111028-4-andrei.simion@microchip.com Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
1 parent 6914cc1 commit 2bd3059

8 files changed

Lines changed: 27 additions & 23 deletions

File tree

‎arch/arm/boot/dts/microchip/aks-cdu.dts‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,23 +98,27 @@
9898
leds {
9999
compatible = "gpio-leds";
100100

101-
red {
101+
led-red {
102+
label = "red";
102103
gpios = <&pioC 10 GPIO_ACTIVE_HIGH>;
103104
linux,default-trigger = "none";
104105
};
105106

106-
green {
107+
led-green {
108+
label = "green";
107109
gpios = <&pioA 5 GPIO_ACTIVE_LOW>;
108110
linux,default-trigger = "none";
109111
default-state = "on";
110112
};
111113

112-
yellow {
114+
led-yellow {
115+
label = "yellow";
113116
gpios = <&pioB 20 GPIO_ACTIVE_LOW>;
114117
linux,default-trigger = "none";
115118
};
116119

117-
blue {
120+
led-blue {
121+
label = "blue";
118122
gpios = <&pioB 21 GPIO_ACTIVE_LOW>;
119123
linux,default-trigger = "none";
120124
};

‎arch/arm/boot/dts/microchip/animeo_ip.dts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,23 +146,23 @@
146146
leds {
147147
compatible = "gpio-leds";
148148

149-
power_green {
149+
led-power-green {
150150
label = "power_green";
151151
gpios = <&pioC 17 GPIO_ACTIVE_HIGH>;
152152
linux,default-trigger = "heartbeat";
153153
};
154154

155-
power_red {
155+
led-power-red {
156156
label = "power_red";
157157
gpios = <&pioA 2 GPIO_ACTIVE_HIGH>;
158158
};
159159

160-
tx_green {
160+
led-tx-green {
161161
label = "tx_green";
162162
gpios = <&pioC 19 GPIO_ACTIVE_HIGH>;
163163
};
164164

165-
tx_red {
165+
led-tx-red {
166166
label = "tx_red";
167167
gpios = <&pioC 18 GPIO_ACTIVE_HIGH>;
168168
};

‎arch/arm/boot/dts/microchip/at91-sam9x60ek.dts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,17 +53,17 @@
5353
pinctrl-0 = <&pinctrl_gpio_leds>;
5454
status = "okay"; /* Conflict with pwm0. */
5555

56-
red {
56+
led-red {
5757
label = "red";
5858
gpios = <&pioB 11 GPIO_ACTIVE_HIGH>;
5959
};
6060

61-
green {
61+
led-green {
6262
label = "green";
6363
gpios = <&pioB 12 GPIO_ACTIVE_HIGH>;
6464
};
6565

66-
blue {
66+
led-blue {
6767
label = "blue";
6868
gpios = <&pioB 13 GPIO_ACTIVE_HIGH>;
6969
linux,default-trigger = "heartbeat";

‎arch/arm/boot/dts/microchip/at91rm9200ek.dts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,19 +127,19 @@
127127
leds {
128128
compatible = "gpio-leds";
129129

130-
ds2 {
130+
led-ds2 {
131131
label = "green";
132132
gpios = <&pioB 0 GPIO_ACTIVE_LOW>;
133133
linux,default-trigger = "mmc0";
134134
};
135135

136-
ds4 {
136+
led-ds4 {
137137
label = "yellow";
138138
gpios = <&pioB 1 GPIO_ACTIVE_LOW>;
139139
linux,default-trigger = "heartbeat";
140140
};
141141

142-
ds6 {
142+
led-ds6 {
143143
label = "red";
144144
gpios = <&pioB 2 GPIO_ACTIVE_LOW>;
145145
};

‎arch/arm/boot/dts/microchip/at91sam9260ek.dts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,13 +174,13 @@
174174
leds {
175175
compatible = "gpio-leds";
176176

177-
ds1 {
177+
led-ds1 {
178178
label = "ds1";
179179
gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
180180
linux,default-trigger = "heartbeat";
181181
};
182182

183-
ds5 {
183+
led-ds5 {
184184
label = "ds5";
185185
gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
186186
};

‎arch/arm/boot/dts/microchip/at91sam9261ek.dts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -192,19 +192,19 @@
192192
leds {
193193
compatible = "gpio-leds";
194194

195-
ds8 {
195+
led-ds8 {
196196
label = "ds8";
197197
gpios = <&pioA 13 GPIO_ACTIVE_LOW>;
198198
linux,default-trigger = "none";
199199
};
200200

201-
ds7 {
201+
led-ds7 {
202202
label = "ds7";
203203
gpios = <&pioA 14 GPIO_ACTIVE_LOW>;
204204
linux,default-trigger = "nand-disk";
205205
};
206206

207-
ds1 {
207+
led-ds1 {
208208
label = "ds1";
209209
gpios = <&pioA 23 GPIO_ACTIVE_LOW>;
210210
linux,default-trigger = "heartbeat";

‎arch/arm/boot/dts/microchip/at91sam9263ek.dts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,13 +219,13 @@
219219
leds {
220220
compatible = "gpio-leds";
221221

222-
d3 {
222+
led-d3 {
223223
label = "d3";
224224
gpios = <&pioB 7 GPIO_ACTIVE_HIGH>;
225225
linux,default-trigger = "heartbeat";
226226
};
227227

228-
d2 {
228+
led-d2 {
229229
label = "d2";
230230
gpios = <&pioC 29 GPIO_ACTIVE_LOW>;
231231
linux,default-trigger = "nand-disk";

‎arch/arm/boot/dts/microchip/at91sam9g20ek.dts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@
1414
leds {
1515
compatible = "gpio-leds";
1616

17-
ds1 {
17+
led-ds1 {
1818
label = "ds1";
1919
gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
2020
linux,default-trigger = "heartbeat";
2121
};
2222

23-
ds5 {
23+
led-ds5 {
2424
label = "ds5";
2525
gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
2626
};

0 commit comments

Comments
 (0)