Skip to content

Commit 2bd5b55

Browse files
jan-kiszkadavem330
authored andcommitted
net: ti: icssg-prueth: Fix error cleanup on failing pruss_request_mem_region
We were just continuing in this case, surely not desired. Fixes: 128d587 ("net: ti: icssg-prueth: Add ICSSG ethernet driver") Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com> Reviewed-by: Roger Quadros <rogerq@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent e409d73 commit 2bd5b55

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/net/ethernet/ti/icssg/icssg_prueth.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2063,7 +2063,7 @@ static int prueth_probe(struct platform_device *pdev)
20632063
&prueth->shram);
20642064
if (ret) {
20652065
dev_err(dev, "unable to get PRUSS SHRD RAM2: %d\n", ret);
2066-
pruss_put(prueth->pruss);
2066+
goto put_pruss;
20672067
}
20682068

20692069
prueth->sram_pool = of_gen_pool_get(np, "sram", 0);
@@ -2215,6 +2215,8 @@ static int prueth_probe(struct platform_device *pdev)
22152215

22162216
put_mem:
22172217
pruss_release_mem_region(prueth->pruss, &prueth->shram);
2218+
2219+
put_pruss:
22182220
pruss_put(prueth->pruss);
22192221

22202222
put_cores:

0 commit comments

Comments
 (0)