Skip to content

Commit 2be189c

Browse files
committed
drm/i915: Relocate vlv_wait_port_ready()
While vlv_wait_port_ready() doens't directly talk to the VLV/CHV DPIO PHY, the signals it's looking for do come from the PHY. So it seems appropriate to relocate it into intel_dpio_phy.c. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250213150220.13580-8-ville.syrjala@linux.intel.com Reviewed-by: Jani Nikula <jani.nikula@intel.com>
1 parent 7105bf9 commit 2be189c

4 files changed

Lines changed: 42 additions & 37 deletions

File tree

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -473,40 +473,6 @@ static void assert_planes_disabled(struct intel_crtc *crtc)
473473
assert_plane_disabled(plane);
474474
}
475475

476-
void vlv_wait_port_ready(struct intel_display *display,
477-
struct intel_digital_port *dig_port,
478-
unsigned int expected_mask)
479-
{
480-
u32 port_mask;
481-
i915_reg_t dpll_reg;
482-
483-
switch (dig_port->base.port) {
484-
default:
485-
MISSING_CASE(dig_port->base.port);
486-
fallthrough;
487-
case PORT_B:
488-
port_mask = DPLL_PORTB_READY_MASK;
489-
dpll_reg = DPLL(display, 0);
490-
break;
491-
case PORT_C:
492-
port_mask = DPLL_PORTC_READY_MASK;
493-
dpll_reg = DPLL(display, 0);
494-
expected_mask <<= 4;
495-
break;
496-
case PORT_D:
497-
port_mask = DPLL_PORTD_READY_MASK;
498-
dpll_reg = DPIO_PHY_STATUS;
499-
break;
500-
}
501-
502-
if (intel_de_wait(display, dpll_reg, port_mask, expected_mask, 1000))
503-
drm_WARN(display->drm, 1,
504-
"timed out waiting for [ENCODER:%d:%s] port ready: got 0x%x, expected 0x%x\n",
505-
dig_port->base.base.base.id, dig_port->base.base.name,
506-
intel_de_read(display, dpll_reg) & port_mask,
507-
expected_mask);
508-
}
509-
510476
void intel_enable_transcoder(const struct intel_crtc_state *new_crtc_state)
511477
{
512478
struct intel_display *display = to_intel_display(new_crtc_state);

drivers/gpu/drm/i915/display/intel_display.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -486,9 +486,6 @@ bool intel_encoder_is_tc(struct intel_encoder *encoder);
486486
enum tc_port intel_encoder_to_tc(struct intel_encoder *encoder);
487487

488488
int ilk_get_lanes_required(int target_clock, int link_bw, int bpp);
489-
void vlv_wait_port_ready(struct intel_display *display,
490-
struct intel_digital_port *dig_port,
491-
unsigned int expected_mask);
492489

493490
bool intel_fuzzy_clock_check(int clock1, int clock2);
494491

drivers/gpu/drm/i915/display/intel_dpio_phy.c

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1156,3 +1156,37 @@ void vlv_phy_reset_lanes(struct intel_encoder *encoder,
11561156
vlv_dpio_write(dev_priv, phy, VLV_PCS_DW1_GRP(ch), 0x00e00060);
11571157
vlv_dpio_put(dev_priv);
11581158
}
1159+
1160+
void vlv_wait_port_ready(struct intel_display *display,
1161+
struct intel_digital_port *dig_port,
1162+
unsigned int expected_mask)
1163+
{
1164+
u32 port_mask;
1165+
i915_reg_t dpll_reg;
1166+
1167+
switch (dig_port->base.port) {
1168+
default:
1169+
MISSING_CASE(dig_port->base.port);
1170+
fallthrough;
1171+
case PORT_B:
1172+
port_mask = DPLL_PORTB_READY_MASK;
1173+
dpll_reg = DPLL(display, 0);
1174+
break;
1175+
case PORT_C:
1176+
port_mask = DPLL_PORTC_READY_MASK;
1177+
dpll_reg = DPLL(display, 0);
1178+
expected_mask <<= 4;
1179+
break;
1180+
case PORT_D:
1181+
port_mask = DPLL_PORTD_READY_MASK;
1182+
dpll_reg = DPIO_PHY_STATUS;
1183+
break;
1184+
}
1185+
1186+
if (intel_de_wait(display, dpll_reg, port_mask, expected_mask, 1000))
1187+
drm_WARN(display->drm, 1,
1188+
"timed out waiting for [ENCODER:%d:%s] port ready: got 0x%x, expected 0x%x\n",
1189+
dig_port->base.base.base.id, dig_port->base.base.name,
1190+
intel_de_read(display, dpll_reg) & port_mask,
1191+
expected_mask);
1192+
}

drivers/gpu/drm/i915/display/intel_dpio_phy.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ void vlv_phy_pre_encoder_enable(struct intel_encoder *encoder,
7272
const struct intel_crtc_state *crtc_state);
7373
void vlv_phy_reset_lanes(struct intel_encoder *encoder,
7474
const struct intel_crtc_state *old_crtc_state);
75+
void vlv_wait_port_ready(struct intel_display *display,
76+
struct intel_digital_port *dig_port,
77+
unsigned int expected_mask);
7578
#else
7679
static inline void bxt_port_to_phy_channel(struct intel_display *display, enum port port,
7780
enum dpio_phy *phy, enum dpio_channel *ch)
@@ -170,6 +173,11 @@ static inline void vlv_phy_reset_lanes(struct intel_encoder *encoder,
170173
const struct intel_crtc_state *old_crtc_state)
171174
{
172175
}
176+
static inline void vlv_wait_port_ready(struct intel_display *display,
177+
struct intel_digital_port *dig_port,
178+
unsigned int expected_mask)
179+
{
180+
}
173181
#endif
174182

175183
#endif /* __INTEL_DPIO_PHY_H__ */

0 commit comments

Comments
 (0)