Skip to content

Commit 2c61f32

Browse files
Wei YongjunLorenzo Pieralisi
authored andcommitted
PCI: microchip: Make some symbols static
The sparse tool complains as follows: drivers/pci/controller/pcie-microchip-host.c:304:18: warning: symbol 'pcie_event_to_event' was not declared. Should it be static? drivers/pci/controller/pcie-microchip-host.c:310:18: warning: symbol 'sec_error_to_event' was not declared. Should it be static? drivers/pci/controller/pcie-microchip-host.c:317:18: warning: symbol 'ded_error_to_event' was not declared. Should it be static? drivers/pci/controller/pcie-microchip-host.c:324:18: warning: symbol 'local_status_to_event' was not declared. Should it be static? Those symbols are not used outside of pcie-microchip-host.c, so this commit marks them static. Link: https://lore.kernel.org/r/20210308094842.3588847-1-weiyongjun1@huawei.com Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
1 parent a38fd87 commit 2c61f32

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/pci/controller/pcie-microchip-host.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,27 +301,27 @@ static const struct cause event_cause[NUM_EVENTS] = {
301301
LOCAL_EVENT_CAUSE(PM_MSI_INT_SYS_ERR, "system error"),
302302
};
303303

304-
struct event_map pcie_event_to_event[] = {
304+
static struct event_map pcie_event_to_event[] = {
305305
PCIE_EVENT_TO_EVENT_MAP(L2_EXIT),
306306
PCIE_EVENT_TO_EVENT_MAP(HOTRST_EXIT),
307307
PCIE_EVENT_TO_EVENT_MAP(DLUP_EXIT),
308308
};
309309

310-
struct event_map sec_error_to_event[] = {
310+
static struct event_map sec_error_to_event[] = {
311311
SEC_ERROR_TO_EVENT_MAP(TX_RAM_SEC_ERR),
312312
SEC_ERROR_TO_EVENT_MAP(RX_RAM_SEC_ERR),
313313
SEC_ERROR_TO_EVENT_MAP(PCIE2AXI_RAM_SEC_ERR),
314314
SEC_ERROR_TO_EVENT_MAP(AXI2PCIE_RAM_SEC_ERR),
315315
};
316316

317-
struct event_map ded_error_to_event[] = {
317+
static struct event_map ded_error_to_event[] = {
318318
DED_ERROR_TO_EVENT_MAP(TX_RAM_DED_ERR),
319319
DED_ERROR_TO_EVENT_MAP(RX_RAM_DED_ERR),
320320
DED_ERROR_TO_EVENT_MAP(PCIE2AXI_RAM_DED_ERR),
321321
DED_ERROR_TO_EVENT_MAP(AXI2PCIE_RAM_DED_ERR),
322322
};
323323

324-
struct event_map local_status_to_event[] = {
324+
static struct event_map local_status_to_event[] = {
325325
LOCAL_STATUS_TO_EVENT_MAP(DMA_END_ENGINE_0),
326326
LOCAL_STATUS_TO_EVENT_MAP(DMA_END_ENGINE_1),
327327
LOCAL_STATUS_TO_EVENT_MAP(DMA_ERROR_ENGINE_0),

0 commit comments

Comments
 (0)