Skip to content

Commit 2d85ecd

Browse files
fschnyderbroonie
authored andcommitted
regulator: pf9453: Respect IRQ trigger settings from firmware
The datasheet specifies, that the IRQ_B pin is pulled low when any unmasked interrupt bit status is changed, and it is released high once the application processor reads the INT1 register. As it specifies a level-low behavior, it should not force a falling-edge interrupt. Remove the IRQF_TRIGGER_FALLING to not force the falling-edge interrupt and instead rely on the flag from the device tree. Fixes: 0959b67 ("regulator: pf9453: add PMIC PF9453 support") Cc: stable@vger.kernel.org Signed-off-by: Franz Schnyder <franz.schnyder@toradex.com> Link: https://patch.msgid.link/20260218102518.238943-2-fra.schnyder@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 23942b7 commit 2d85ecd

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/regulator/pf9453-regulator.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,7 @@ static int pf9453_i2c_probe(struct i2c_client *i2c)
809809
}
810810

811811
ret = devm_request_threaded_irq(pf9453->dev, pf9453->irq, NULL, pf9453_irq_handler,
812-
(IRQF_TRIGGER_FALLING | IRQF_ONESHOT),
812+
IRQF_ONESHOT,
813813
"pf9453-irq", pf9453);
814814
if (ret)
815815
return dev_err_probe(pf9453->dev, ret, "Failed to request IRQ: %d\n", pf9453->irq);

0 commit comments

Comments
 (0)