Skip to content

Commit 2dea984

Browse files
rafaeljwWim Van Sebroeck
authored andcommitted
watchdog: rzv2h_wdt: Discard pm_runtime_put() return value
Failing device probe due to pm_runtime_put() returning an error is not particularly useful. Returning an error code from pm_runtime_put() merely means that it has not queued up a work item to check whether or not the device can be suspended and there are many perfectly valid situations in which that can happen, like after writing "on" to the devices' runtime PM "control" attribute in sysfs for one example. It also happens when the kernel is configured with CONFIG_PM unset. Accordingly, update rzt2h_wdt_wdtdcr_init() to simply discard the return value of pm_runtime_put() and return success to the caller after invoking that function. This will facilitate a planned change of the pm_runtime_put() return type to void in the future. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
1 parent 4a4da48 commit 2dea984

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/watchdog/rzv2h_wdt.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -268,9 +268,7 @@ static int rzt2h_wdt_wdtdcr_init(struct platform_device *pdev,
268268

269269
rzt2h_wdt_wdtdcr_count_stop(priv);
270270

271-
ret = pm_runtime_put(&pdev->dev);
272-
if (ret < 0)
273-
return ret;
271+
pm_runtime_put(&pdev->dev);
274272

275273
return 0;
276274
}

0 commit comments

Comments
 (0)