Skip to content

Commit 2dee50a

Browse files
rfs613geertu
authored andcommitted
clk: renesas: r9a06g032: Fix UART clkgrp bitsel
There are two UART clock groups, each having a mux to select its upstream clock source. The register/bit definitions for accessing these two muxes appear to have been reversed since introduction. Correct them so as to match the hardware manual. Fixes: 4c3d885 ("clk: renesas: Renesas R9A06G032 clock driver") Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org> Reviewed-by: Phil Edworthy <phil.edworthy@renesas.com> Link: https://lore.kernel.org/r/20220518182527.1693156-1-ralph.siemsen@linaro.org Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
1 parent f46efcc commit 2dee50a

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/clk/renesas/r9a06g032-clocks.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -288,17 +288,17 @@ static const struct r9a06g032_clkdesc r9a06g032_clocks[] = {
288288
.name = "uart_group_012",
289289
.type = K_BITSEL,
290290
.source = 1 + R9A06G032_DIV_UART,
291-
/* R9A06G032_SYSCTRL_REG_PWRCTRL_PG1_PR2 */
292-
.dual.sel = ((0xec / 4) << 5) | 24,
291+
/* R9A06G032_SYSCTRL_REG_PWRCTRL_PG0_0 */
292+
.dual.sel = ((0x34 / 4) << 5) | 30,
293293
.dual.group = 0,
294294
},
295295
{
296296
.index = R9A06G032_UART_GROUP_34567,
297297
.name = "uart_group_34567",
298298
.type = K_BITSEL,
299299
.source = 1 + R9A06G032_DIV_P2_PG,
300-
/* R9A06G032_SYSCTRL_REG_PWRCTRL_PG0_0 */
301-
.dual.sel = ((0x34 / 4) << 5) | 30,
300+
/* R9A06G032_SYSCTRL_REG_PWRCTRL_PG1_PR2 */
301+
.dual.sel = ((0xec / 4) << 5) | 24,
302302
.dual.group = 1,
303303
},
304304
D_UGATE(CLK_UART0, "clk_uart0", UART_GROUP_012, 0, 0x1b2, 0x1b3, 0x1b4, 0x1b5),

0 commit comments

Comments
 (0)