Skip to content

Commit 2e1139d

Browse files
Zhang Changzhongmstsirkin
authored andcommitted
vhost scsi: fix error return code in vhost_scsi_set_endpoint()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 25b98b6 ("vhost scsi: alloc cmds per vq instead of session") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> Link: https://lore.kernel.org/r/1607071411-33484-1-git-send-email-zhangchangzhong@huawei.com Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
1 parent e152d8a commit 2e1139d

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/vhost/scsi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
16431643
if (!vhost_vq_is_setup(vq))
16441644
continue;
16451645

1646-
if (vhost_scsi_setup_vq_cmds(vq, vq->num))
1646+
ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
1647+
if (ret)
16471648
goto destroy_vq_cmds;
16481649
}
16491650

0 commit comments

Comments
 (0)