Skip to content

Commit 2e84dc3

Browse files
Saravana Kannangregkh
authored andcommitted
driver core: Release all resources during unbind before updating device links
This commit fixes a bug in commit 9ed9895 ("driver core: Functional dependencies tracking support") where the device link status was incorrectly updated in the driver unbind path before all the device's resources were released. Fixes: 9ed9895 ("driver core: Functional dependencies tracking support") Cc: stable <stable@kernel.org> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Closes: https://lore.kernel.org/all/20231014161721.f4iqyroddkcyoefo@pengutronix.de/ Signed-off-by: Saravana Kannan <saravanak@google.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Yang Yingliang <yangyingliang@huawei.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Mark Brown <broonie@kernel.org> Cc: Matti Vaittinen <mazziesaccount@gmail.com> Cc: James Clark <james.clark@arm.com> Acked-by: "Rafael J. Wysocki" <rafael@kernel.org> Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20231018013851.3303928-1-saravanak@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 28f2d57 commit 2e84dc3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/base/dd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1274,8 +1274,8 @@ static void __device_release_driver(struct device *dev, struct device *parent)
12741274
if (dev->bus && dev->bus->dma_cleanup)
12751275
dev->bus->dma_cleanup(dev);
12761276

1277-
device_links_driver_cleanup(dev);
12781277
device_unbind_cleanup(dev);
1278+
device_links_driver_cleanup(dev);
12791279

12801280
klist_remove(&dev->p->knode_driver);
12811281
device_pm_check_callbacks(dev);

0 commit comments

Comments
 (0)