Skip to content

Commit 2e958a8

Browse files
masahir0yKAGA-KOKO
authored andcommitted
x86/entry/x32: Rename __x32_compat_sys_* to __x64_compat_sys_*
The SYSCALL macros are mapped to symbols as follows: __SYSCALL_COMMON(nr, sym) --> __x64_<sym> __SYSCALL_X32(nr, sym) --> __x32_<sym> Originally, the syscalls in the x32 special range (512-547) were all compat. This assumption is now broken after the following commits: 55db9c0 ("net: remove compat_sys_{get,set}sockopt") 5f764d6 ("fs: remove the compat readv/writev syscalls") 598b3ce ("fs: remove compat_sys_vmsplice") c3973b4 ("mm: remove compat_process_vm_{readv,writev}") Those commits redefined __x32_sys_* to __x64_sys_* because there is no stub like __x32_sys_*. Defining them as follows is more sensible and cleaner. __SYSCALL_COMMON(nr, sym) --> __x64_<sym> __SYSCALL_X32(nr, sym) --> __x64_<sym> This works because both x86_64 and x32 use the same ABI (RDI, RSI, RDX, R10, R8, R9) The ugly #define __x32_sys_* will go away. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/r/20210517073815.97426-2-masahiroy@kernel.org
1 parent 41f45fb commit 2e958a8

2 files changed

Lines changed: 7 additions & 19 deletions

File tree

arch/x86/entry/syscall_x32.c

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,15 @@
88
#include <asm/unistd.h>
99
#include <asm/syscall.h>
1010

11-
/*
12-
* Reuse the 64-bit entry points for the x32 versions that occupy different
13-
* slots in the syscall table.
14-
*/
15-
#define __x32_sys_readv __x64_sys_readv
16-
#define __x32_sys_writev __x64_sys_writev
17-
#define __x32_sys_getsockopt __x64_sys_getsockopt
18-
#define __x32_sys_setsockopt __x64_sys_setsockopt
19-
#define __x32_sys_vmsplice __x64_sys_vmsplice
20-
#define __x32_sys_process_vm_readv __x64_sys_process_vm_readv
21-
#define __x32_sys_process_vm_writev __x64_sys_process_vm_writev
22-
2311
#define __SYSCALL_64(nr, sym)
2412

25-
#define __SYSCALL_X32(nr, sym) extern long __x32_##sym(const struct pt_regs *);
13+
#define __SYSCALL_X32(nr, sym) extern long __x64_##sym(const struct pt_regs *);
2614
#define __SYSCALL_COMMON(nr, sym) extern long __x64_##sym(const struct pt_regs *);
2715
#include <asm/syscalls_64.h>
2816
#undef __SYSCALL_X32
2917
#undef __SYSCALL_COMMON
3018

31-
#define __SYSCALL_X32(nr, sym) [nr] = __x32_##sym,
19+
#define __SYSCALL_X32(nr, sym) [nr] = __x64_##sym,
3220
#define __SYSCALL_COMMON(nr, sym) [nr] = __x64_##sym,
3321

3422
asmlinkage const sys_call_ptr_t x32_sys_call_table[__NR_x32_syscall_max+1] = {

arch/x86/include/asm/syscall_wrapper.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ extern long __ia32_sys_ni_syscall(const struct pt_regs *regs);
1717
* __x64_sys_*() - 64-bit native syscall
1818
* __ia32_sys_*() - 32-bit native syscall or common compat syscall
1919
* __ia32_compat_sys_*() - 32-bit compat syscall
20-
* __x32_compat_sys_*() - 64-bit X32 compat syscall
20+
* __x64_compat_sys_*() - 64-bit X32 compat syscall
2121
*
2222
* The registers are decoded according to the ABI:
2323
* 64-bit: RDI, RSI, RDX, R10, R8, R9
@@ -166,17 +166,17 @@ extern long __ia32_sys_ni_syscall(const struct pt_regs *regs);
166166
* with x86_64 obviously do not need such care.
167167
*/
168168
#define __X32_COMPAT_SYS_STUB0(name) \
169-
__SYS_STUB0(x32, compat_sys_##name)
169+
__SYS_STUB0(x64, compat_sys_##name)
170170

171171
#define __X32_COMPAT_SYS_STUBx(x, name, ...) \
172-
__SYS_STUBx(x32, compat_sys##name, \
172+
__SYS_STUBx(x64, compat_sys##name, \
173173
SC_X86_64_REGS_TO_ARGS(x, __VA_ARGS__))
174174

175175
#define __X32_COMPAT_COND_SYSCALL(name) \
176-
__COND_SYSCALL(x32, compat_sys_##name)
176+
__COND_SYSCALL(x64, compat_sys_##name)
177177

178178
#define __X32_COMPAT_SYS_NI(name) \
179-
__SYS_NI(x32, compat_sys_##name)
179+
__SYS_NI(x64, compat_sys_##name)
180180
#else /* CONFIG_X86_X32 */
181181
#define __X32_COMPAT_SYS_STUB0(name)
182182
#define __X32_COMPAT_SYS_STUBx(x, name, ...)

0 commit comments

Comments
 (0)