Skip to content

Commit 2ebadb6

Browse files
olsajiriAlexei Starovoitov
authored andcommitted
bpf: Return error for missed kprobe multi bpf program execution
When kprobe multi bpf program can't be executed due to recursion check, we currently return 0 (success) to fprobe layer where it's ignored for standard kprobe multi probes. For kprobe session the success return value will make fprobe layer to install return probe and try to execute it as well. But the return session probe should not get executed, because the entry part did not run. FWIW the return probe bpf program most likely won't get executed, because its recursion check will likely fail as well, but we don't need to run it in the first place.. also we can make this clear and obvious. It also affects missed counts for kprobe session program execution, which are now doubled (extra count for not executed return probe). Signed-off-by: Jiri Olsa <jolsa@kernel.org> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Link: https://lore.kernel.org/r/20250106175048.1443905-1-jolsa@kernel.org Signed-off-by: Alexei Starovoitov <ast@kernel.org>
1 parent ca3c4f6 commit 2ebadb6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

kernel/trace/bpf_trace.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2802,7 +2802,7 @@ kprobe_multi_link_prog_run(struct bpf_kprobe_multi_link *link,
28022802

28032803
if (unlikely(__this_cpu_inc_return(bpf_prog_active) != 1)) {
28042804
bpf_prog_inc_misses_counter(link->link.prog);
2805-
err = 0;
2805+
err = 1;
28062806
goto out;
28072807
}
28082808

0 commit comments

Comments
 (0)