pwm: tegra: Assert reset only after the PWM was unregistered

Uwe Kleine-König · thierryreding · commit 2f1a3bd4510a · 2021-06-30T19:12:20.000+02:00
The driver is supposed to stay functional until pwmchip_remove()
returns. So the reset must be asserted only after that.

pwmchip_remove() always returns 0, so the return code can be ignored
which keeps the tegra_pwm_remove() a bit simpler.

Signed-off-by: Uwe Kleine-König &lt;u.kleine-koenig@pengutronix.de&gt;
Signed-off-by: Thierry Reding &lt;thierry.reding@gmail.com&gt;
diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
@@ -301,9 +301,11 @@ static int tegra_pwm_remove(struct platform_device *pdev)
 {
 	struct tegra_pwm_chip *pc = platform_get_drvdata(pdev);
 
+	pwmchip_remove(&pc->chip);
+
 	reset_control_assert(pc->rst);
 
-	return pwmchip_remove(&pc->chip);
+	return 0;
 }
 
 #ifdef CONFIG_PM_SLEEP

Original file line number	Diff line number	Diff line change
`@@ -301,9 +301,11 @@ static int tegra_pwm_remove(struct platform_device *pdev)`
`301`	`301`	`{`
`302`	`302`	`struct tegra_pwm_chip *pc = platform_get_drvdata(pdev);`
`303`	`303`
	`304`	`+ pwmchip_remove(&pc->chip);`
	`305`	`+`
`304`	`306`	`reset_control_assert(pc->rst);`
`305`	`307`
`306`		`- return pwmchip_remove(&pc->chip);`
	`308`	`+ return 0;`
`307`	`309`	`}`
`308`	`310`
`309`	`311`	`#ifdef CONFIG_PM_SLEEP`