Skip to content

Commit 2f4113b

Browse files
azeemshaikh38kees
authored andcommitted
scsi: qedi: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] KSPP#89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20230517143509.1520387-1-azeemshaikh38@gmail.com
1 parent 3b92d34 commit 2f4113b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/scsi/qedi/qedi_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2593,7 +2593,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
25932593
sp_params.drv_minor = QEDI_DRIVER_MINOR_VER;
25942594
sp_params.drv_rev = QEDI_DRIVER_REV_VER;
25952595
sp_params.drv_eng = QEDI_DRIVER_ENG_VER;
2596-
strlcpy(sp_params.name, "qedi iSCSI", QED_DRV_VER_STR_SIZE);
2596+
strscpy(sp_params.name, "qedi iSCSI", QED_DRV_VER_STR_SIZE);
25972597
rc = qedi_ops->common->slowpath_start(qedi->cdev, &sp_params);
25982598
if (rc) {
25992599
QEDI_ERR(&qedi->dbg_ctx, "Cannot start slowpath\n");

0 commit comments

Comments
 (0)