Skip to content

Commit 2f658f7

Browse files
committed
pinctrl: tigerlake: Fix GPIO mapping for newer version of software
The software mapping for GPIO, which initially comes from Microsoft, is subject to change by respective Windows and firmware developers. Due to the above the driver had been written and published way ahead of the schedule, and thus the numbering schema used in it is outdated. Fix the numbering schema in accordance with the real products on market. Fixes: 653d964 ("pinctrl: tigerlake: Add support for Tiger Lake-H") Reported-and-tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Reported-by: Riccardo Mori <patacca@autistici.org> Reported-and-tested-by: Lovesh <lovesh.bond@gmail.com> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213463 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213579 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213857 Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
1 parent e73f0f0 commit 2f658f7

1 file changed

Lines changed: 13 additions & 13 deletions

File tree

drivers/pinctrl/intel/pinctrl-tigerlake.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -701,32 +701,32 @@ static const struct pinctrl_pin_desc tglh_pins[] = {
701701

702702
static const struct intel_padgroup tglh_community0_gpps[] = {
703703
TGL_GPP(0, 0, 24, 0), /* GPP_A */
704-
TGL_GPP(1, 25, 44, 128), /* GPP_R */
705-
TGL_GPP(2, 45, 70, 32), /* GPP_B */
706-
TGL_GPP(3, 71, 78, INTEL_GPIO_BASE_NOMAP), /* vGPIO_0 */
704+
TGL_GPP(1, 25, 44, 32), /* GPP_R */
705+
TGL_GPP(2, 45, 70, 64), /* GPP_B */
706+
TGL_GPP(3, 71, 78, 96), /* vGPIO_0 */
707707
};
708708

709709
static const struct intel_padgroup tglh_community1_gpps[] = {
710-
TGL_GPP(0, 79, 104, 96), /* GPP_D */
711-
TGL_GPP(1, 105, 128, 64), /* GPP_C */
712-
TGL_GPP(2, 129, 136, 160), /* GPP_S */
713-
TGL_GPP(3, 137, 153, 192), /* GPP_G */
714-
TGL_GPP(4, 154, 180, 224), /* vGPIO */
710+
TGL_GPP(0, 79, 104, 128), /* GPP_D */
711+
TGL_GPP(1, 105, 128, 160), /* GPP_C */
712+
TGL_GPP(2, 129, 136, 192), /* GPP_S */
713+
TGL_GPP(3, 137, 153, 224), /* GPP_G */
714+
TGL_GPP(4, 154, 180, 256), /* vGPIO */
715715
};
716716

717717
static const struct intel_padgroup tglh_community3_gpps[] = {
718-
TGL_GPP(0, 181, 193, 256), /* GPP_E */
719-
TGL_GPP(1, 194, 217, 288), /* GPP_F */
718+
TGL_GPP(0, 181, 193, 288), /* GPP_E */
719+
TGL_GPP(1, 194, 217, 320), /* GPP_F */
720720
};
721721

722722
static const struct intel_padgroup tglh_community4_gpps[] = {
723-
TGL_GPP(0, 218, 241, 320), /* GPP_H */
723+
TGL_GPP(0, 218, 241, 352), /* GPP_H */
724724
TGL_GPP(1, 242, 251, 384), /* GPP_J */
725-
TGL_GPP(2, 252, 266, 352), /* GPP_K */
725+
TGL_GPP(2, 252, 266, 416), /* GPP_K */
726726
};
727727

728728
static const struct intel_padgroup tglh_community5_gpps[] = {
729-
TGL_GPP(0, 267, 281, 416), /* GPP_I */
729+
TGL_GPP(0, 267, 281, 448), /* GPP_I */
730730
TGL_GPP(1, 282, 290, INTEL_GPIO_BASE_NOMAP), /* JTAG */
731731
};
732732

0 commit comments

Comments
 (0)