Skip to content

Commit 302aeb9

Browse files
lumagsuperna9999
authored andcommitted
drm/panel: novatek-nt36672e: stop setting register load before disable
It is pointless to set register load before disabling the register. This vote is going to be dropped as soon as the register is disabled. Drop these register_set_load calls. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/r/20240404-drop-panel-unregister-v1-3-9f56953c5fb9@linaro.org Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240404-drop-panel-unregister-v1-3-9f56953c5fb9@linaro.org
1 parent 6abe93b commit 302aeb9

1 file changed

Lines changed: 0 additions & 17 deletions

File tree

drivers/gpu/drm/panel/panel-novatek-nt36672e.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@ static const unsigned long regulator_enable_loads[] = {
2525
100000,
2626
};
2727

28-
static const unsigned long regulator_disable_loads[] = {
29-
80,
30-
100,
31-
100,
32-
};
33-
3428
struct panel_desc {
3529
const struct drm_display_mode *display_mode;
3630
u32 width_mm;
@@ -385,20 +379,9 @@ static int nt36672e_power_off(struct nt36672e_panel *ctx)
385379
{
386380
struct mipi_dsi_device *dsi = ctx->dsi;
387381
int ret = 0;
388-
int i;
389382

390383
gpiod_set_value(ctx->reset_gpio, 0);
391384

392-
for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) {
393-
ret = regulator_set_load(ctx->supplies[i].consumer,
394-
regulator_disable_loads[i]);
395-
if (ret) {
396-
dev_err(&dsi->dev, "regulator set load failed for supply %s: %d\n",
397-
ctx->supplies[i].supply, ret);
398-
return ret;
399-
}
400-
}
401-
402385
ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
403386
if (ret)
404387
dev_err(&dsi->dev, "regulator bulk disable failed: %d\n", ret);

0 commit comments

Comments
 (0)