Skip to content

Commit 3059d9b

Browse files
committed
drm/vmwgfx: Initialize drm_mode_fb_cmd2
Transition to drm_mode_fb_cmd2 from drm_mode_fb_cmd left the structure unitialized. drm_mode_fb_cmd2 adds a few additional members, e.g. flags and modifiers which were never initialized. Garbage in those members can cause random failures during the bringup of the fbcon. Initializing the structure fixes random blank screens after bootup due to flags/modifiers mismatches during the fbcon bring up. Fixes: dabdcdc ("drm/vmwgfx: Switch to mode_cmd2") Signed-off-by: Zack Rusin <zackr@vmware.com> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: <stable@vger.kernel.org> # v4.10+ Reviewed-by: Martin Krastev <krastevm@vmware.com> Reviewed-by: Maaz Mombasawala <mombasawalam@vmware.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220302152426.885214-7-zack@kde.org
1 parent 1d6595b commit 3059d9b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/vmwgfx/vmwgfx_fb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ static int vmw_fb_kms_detach(struct vmw_fb_par *par,
483483

484484
static int vmw_fb_kms_framebuffer(struct fb_info *info)
485485
{
486-
struct drm_mode_fb_cmd2 mode_cmd;
486+
struct drm_mode_fb_cmd2 mode_cmd = {0};
487487
struct vmw_fb_par *par = info->par;
488488
struct fb_var_screeninfo *var = &info->var;
489489
struct drm_framebuffer *cur_fb;

0 commit comments

Comments
 (0)