Skip to content

Commit 3092718

Browse files
vincent-mailholhdeller
authored andcommitted
video/logo: remove logo_mac_clut224
The logo_mac_clut224 depends on the runtime value MACH_IS_MAC being true to be displayed. This makes that logo a one-of-a-kind, as it is the only one whose selection can not be decided at compile time. This dynamic logo selection logic conflicts with our upcoming plans to simplify the logo selection code. Considering that the logo_mac_clut224 is only used by the Macintosh 68k, a machine whose sales ended some thirty years ago and which thus represents a very small user base, it is preferable to resolve the conflict in favour of code simplicity. Remove the logo_mac_clut224 so that the logo selection can be statically determined at compile time. The users who wish to continue using that logo can still download it from [1] and add: CONFIG_LOGO_LINUX_CLUT224=y CONFIG_LOGO_LINUX_CLUT224_FILE="/path/to/logo_mac_clut224.ppm" to their configuration file to restore it. [1] logo_mac_clut224.ppm file Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/drivers/video/logo/logo_mac_clut224.ppm?h=v6.18 Signed-off-by: Vincent Mailhol <mailhol@kernel.org> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 9db021e commit 3092718

5 files changed

Lines changed: 1 addition & 1616 deletions

File tree

drivers/video/logo/Kconfig

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,6 @@ config LOGO_DEC_CLUT224
7676
depends on MACH_DECSTATION || ALPHA
7777
default y
7878

79-
config LOGO_MAC_CLUT224
80-
bool "224-color Macintosh Linux logo"
81-
depends on MAC
82-
default y
8379

8480
config LOGO_PARISC_CLUT224
8581
bool "224-color PA-RISC Linux logo"

drivers/video/logo/Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ obj-$(CONFIG_LOGO_LINUX_MONO) += logo_linux_mono.o
66
obj-$(CONFIG_LOGO_LINUX_VGA16) += logo_linux_vga16.o
77
obj-$(CONFIG_LOGO_LINUX_CLUT224) += logo_linux_clut224.o
88
obj-$(CONFIG_LOGO_DEC_CLUT224) += logo_dec_clut224.o
9-
obj-$(CONFIG_LOGO_MAC_CLUT224) += logo_mac_clut224.o
109
obj-$(CONFIG_LOGO_PARISC_CLUT224) += logo_parisc_clut224.o
1110
obj-$(CONFIG_LOGO_SGI_CLUT224) += logo_sgi_clut224.o
1211
obj-$(CONFIG_LOGO_SUN_CLUT224) += logo_sun_clut224.o
@@ -20,7 +19,7 @@ obj-$(CONFIG_SPU_BASE) += logo_spe_clut224.o
2019

2120
hostprogs := pnmtologo
2221

23-
# Create commands like "pnmtologo -t mono -n logo_mac_mono -o ..."
22+
# Create commands like "pnmtologo -t mono -n logo_linux_mono -o ..."
2423
quiet_cmd_logo = LOGO $@
2524
cmd_logo = $(obj)/pnmtologo -t $2 -n $(basename $(notdir $@)) -o $@ $<
2625

drivers/video/logo/logo.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,6 @@ const struct linux_logo * __ref fb_find_logo(int depth)
7979
/* DEC Linux logo on MIPS/MIPS64 or ALPHA */
8080
logo = &logo_dec_clut224;
8181
#endif
82-
#ifdef CONFIG_LOGO_MAC_CLUT224
83-
/* Macintosh Linux logo on m68k */
84-
if (MACH_IS_MAC)
85-
logo = &logo_mac_clut224;
86-
#endif
8782
#ifdef CONFIG_LOGO_PARISC_CLUT224
8883
/* PA-RISC Linux logo */
8984
logo = &logo_parisc_clut224;

0 commit comments

Comments
 (0)