net: lan743x: Simplify comparison

mfischer · kuba-moo · commit 30ac666a2fcc · 2023-06-27T09:53:00.000-07:00
Simplify comparison, no functional changes. Cc: Bryan Whitehead <bryan.whitehead@microchip.com> Cc: UNGLinuxDriver@microchip.com Suggested-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Moritz Fischer <moritzf@google.com> Link: https://lore.kernel.org/r/20230627035432.1296760-1-moritzf@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -152,7 +152,7 @@ static int lan743x_csr_wait_for_bit(struct lan743x_adapter *adapter,
 	u32 data;
 
 	return readx_poll_timeout(LAN743X_CSR_READ_OP, offset, data,
-				  target_value == ((data & bit_mask) ? 1 : 0),
+				  target_value == !!(data & bit_mask),
 				  usleep_max, usleep_min * count);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ static int lan743x_csr_wait_for_bit(struct lan743x_adapter *adapter,`
`152`	`152`	`u32 data;`
`153`	`153`
`154`	`154`	`return readx_poll_timeout(LAN743X_CSR_READ_OP, offset, data,`
`155`		`- target_value == ((data & bit_mask) ? 1 : 0),`
	`155`	`+ target_value == !!(data & bit_mask),`
`156`	`156`	`usleep_max, usleep_min * count);`
`157`	`157`	`}`
`158`	`158`