Skip to content

Commit 31adf23

Browse files
committed
livepatch: Convert error about unsupported reliable stacktrace into a warning
The commit d0807da ("livepatch: Remove immediate feature") caused that any livepatch was refused when reliable stacktraces were not supported on the given architecture. The limitation is too strong. User space processes are safely migrated even when entering or leaving the kernel. Kthreads transition would need to get forced. But it is safe when: + The livepatch does not change the semantic of the code. + Callbacks do not depend on a safely finished transition. Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com> Acked-by: Miroslav Benes <mbenes@suse.cz> Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Signed-off-by: Petr Mladek <pmladek@suse.com>
1 parent 43bd3a9 commit 31adf23

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

kernel/livepatch/core.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1003,11 +1003,10 @@ int klp_enable_patch(struct klp_patch *patch)
10031003
return -ENODEV;
10041004

10051005
if (!klp_have_reliable_stack()) {
1006-
pr_err("This architecture doesn't have support for the livepatch consistency model.\n");
1007-
return -EOPNOTSUPP;
1006+
pr_warn("This architecture doesn't have support for the livepatch consistency model.\n");
1007+
pr_warn("The livepatch transition may never complete.\n");
10081008
}
10091009

1010-
10111010
mutex_lock(&klp_mutex);
10121011

10131012
ret = klp_init_patch_early(patch);

0 commit comments

Comments
 (0)