Skip to content

Commit 31c9450

Browse files
Uwe Kleine-Königalexandrebelloni
authored andcommitted
rtc: tegra: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230304133028.2135435-36-u.kleine-koenig@pengutronix.de Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent d6f5250 commit 31c9450

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/rtc/rtc-tegra.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -342,13 +342,11 @@ static int tegra_rtc_probe(struct platform_device *pdev)
342342
return ret;
343343
}
344344

345-
static int tegra_rtc_remove(struct platform_device *pdev)
345+
static void tegra_rtc_remove(struct platform_device *pdev)
346346
{
347347
struct tegra_rtc_info *info = platform_get_drvdata(pdev);
348348

349349
clk_disable_unprepare(info->clk);
350-
351-
return 0;
352350
}
353351

354352
#ifdef CONFIG_PM_SLEEP
@@ -401,7 +399,7 @@ static void tegra_rtc_shutdown(struct platform_device *pdev)
401399

402400
static struct platform_driver tegra_rtc_driver = {
403401
.probe = tegra_rtc_probe,
404-
.remove = tegra_rtc_remove,
402+
.remove_new = tegra_rtc_remove,
405403
.shutdown = tegra_rtc_shutdown,
406404
.driver = {
407405
.name = "tegra_rtc",

0 commit comments

Comments
 (0)