Skip to content

Commit 31e203e

Browse files
Daejun7Parktytso
authored andcommitted
ext4: fix wrong list_splice in ext4_fc_cleanup
After full/fast commit, entries in staging queue are promoted to main queue. In ext4_fs_cleanup function, it splice to staging queue to staging queue. Fixes: aa75f4d ("ext4: main fast-commit commit path") Signed-off-by: Daejun Park <daejun7.park@samsung.com> Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com> Link: https://lore.kernel.org/r/20201230094851epcms2p6eeead8cc984379b37b2efd21af90fd1a@epcms2p6 Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: stable@kernel.org
1 parent 23dd561 commit 31e203e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/ext4/fast_commit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1268,7 +1268,7 @@ static void ext4_fc_cleanup(journal_t *journal, int full)
12681268
list_splice_init(&sbi->s_fc_dentry_q[FC_Q_STAGING],
12691269
&sbi->s_fc_dentry_q[FC_Q_MAIN]);
12701270
list_splice_init(&sbi->s_fc_q[FC_Q_STAGING],
1271-
&sbi->s_fc_q[FC_Q_STAGING]);
1271+
&sbi->s_fc_q[FC_Q_MAIN]);
12721272

12731273
ext4_clear_mount_flag(sb, EXT4_MF_FC_COMMITTING);
12741274
ext4_clear_mount_flag(sb, EXT4_MF_FC_INELIGIBLE);

0 commit comments

Comments
 (0)