Skip to content

Commit 31e721f

Browse files
KamilDuljasbroonie
authored andcommitted
ASoC: SOF: topology: Fix mem leak in sof_dai_load()
The function has multiple return points at which it is not released previously allocated memory. Signed-off-by: Kamil Duljas <kamil.duljas@gmail.com> Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Link: https://lore.kernel.org/r/20231116213926.2034-2-kamil.duljas@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent c1501f2 commit 31e721f

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

sound/soc/sof/topology.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1736,8 +1736,10 @@ static int sof_dai_load(struct snd_soc_component *scomp, int index,
17361736
/* perform pcm set op */
17371737
if (ipc_pcm_ops && ipc_pcm_ops->pcm_setup) {
17381738
ret = ipc_pcm_ops->pcm_setup(sdev, spcm);
1739-
if (ret < 0)
1739+
if (ret < 0) {
1740+
kfree(spcm);
17401741
return ret;
1742+
}
17411743
}
17421744

17431745
dai_drv->dobj.private = spcm;

0 commit comments

Comments
 (0)