Skip to content

Commit 31f190e

Browse files
Dafna Hirschfeldmchehab
authored andcommitted
media: rkisp1: uapi: change hist_bins array type from __u16 to __u32
Each entry in the array is a 20 bits value composed of 16 bits unsigned integer and 4 bits fractional part. So the type should change to __u32. In addition add a documentation of how the measurements are done. Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Acked-by: Helen Koike <helen.koike@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
1 parent e081863 commit 31f190e

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

include/uapi/linux/rkisp1-config.h

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -844,13 +844,18 @@ struct rkisp1_cif_isp_af_stat {
844844
/**
845845
* struct rkisp1_cif_isp_hist_stat - statistics histogram data
846846
*
847-
* @hist_bins: measured bin counters
847+
* @hist_bins: measured bin counters. Each bin is a 20 bits unsigned fixed point
848+
* type. Bits 0-4 are the fractional part and bits 5-19 are the
849+
* integer part.
848850
*
849-
* Measurement window divided into 25 sub-windows, set
850-
* with ISP_HIST_XXX
851+
* The window of the measurements area is divided to 5x5 sub-windows. The
852+
* histogram is then computed for each sub-window independently and the final
853+
* result is a weighted average of the histogram measurements on all
854+
* sub-windows. The window of the measurements area and the weight of each
855+
* sub-window are configurable using struct @rkisp1_cif_isp_hst_config.
851856
*/
852857
struct rkisp1_cif_isp_hist_stat {
853-
__u16 hist_bins[RKISP1_CIF_ISP_HIST_BIN_N_MAX];
858+
__u32 hist_bins[RKISP1_CIF_ISP_HIST_BIN_N_MAX];
854859
};
855860

856861
/**

0 commit comments

Comments
 (0)