Skip to content

Commit 3213bfd

Browse files
azeemshaikh38kees
authored andcommitted
drm/mediatek: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] KSPP#89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20230522155306.2336889-1-azeemshaikh38@gmail.com
1 parent 576f0d7 commit 3213bfd

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev)
295295
return ret;
296296
}
297297

298-
strlcpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name));
298+
strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name));
299299
ddc->adap.owner = THIS_MODULE;
300300
ddc->adap.class = I2C_CLASS_DDC;
301301
ddc->adap.algo = &mtk_hdmi_ddc_algorithm;

0 commit comments

Comments
 (0)