Skip to content

Commit 32788be

Browse files
John GarryDamien Le Moal
authored andcommitted
ata: pata_cs5535: Fix W=1 warnings
x86_64 allmodconfig build with W=1 gives these warnings: drivers/ata/pata_cs5535.c: In function ‘cs5535_set_piomode’: drivers/ata/pata_cs5535.c:93:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable] u32 reg, dummy; ^~~~~ drivers/ata/pata_cs5535.c: In function ‘cs5535_set_dmamode’: drivers/ata/pata_cs5535.c:132:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable] u32 reg, dummy; ^~~~~ cc1: all warnings being treated as errors Mark variables 'dummy' as "maybe unused" as they are only ever written in rdmsr() calls. Signed-off-by: John Garry <john.garry@huawei.com> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
1 parent 540a92b commit 32788be

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/ata/pata_cs5535.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ static void cs5535_set_piomode(struct ata_port *ap, struct ata_device *adev)
9090
static const u16 pio_cmd_timings[5] = {
9191
0xF7F4, 0x53F3, 0x13F1, 0x5131, 0x1131
9292
};
93-
u32 reg, dummy;
93+
u32 reg, __maybe_unused dummy;
9494
struct ata_device *pair = ata_dev_pair(adev);
9595

9696
int mode = adev->pio_mode - XFER_PIO_0;
@@ -129,7 +129,7 @@ static void cs5535_set_dmamode(struct ata_port *ap, struct ata_device *adev)
129129
static const u32 mwdma_timings[3] = {
130130
0x7F0FFFF3, 0x7F035352, 0x7F024241
131131
};
132-
u32 reg, dummy;
132+
u32 reg, __maybe_unused dummy;
133133
int mode = adev->dma_mode;
134134

135135
rdmsr(ATAC_CH0D0_DMA + 2 * adev->devno, reg, dummy);

0 commit comments

Comments
 (0)