gpio: gpio-xilinx: Fix integer overflow

Srinivas Neeli · brgl · commit 32c094a09d58 · 2022-07-22T09:17:03.000+02:00
Current implementation is not able to configure more than 32 pins due to incorrect data type. So type casting with unsigned long to avoid it. Fixes: 02b3f84 ("xilinx: Switch to use bitmap APIs") Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
@@ -99,7 +99,7 @@ static inline void xgpio_set_value32(unsigned long *map, int bit, u32 v)
 	const unsigned long offset = (bit % BITS_PER_LONG) & BIT(5);
 
 	map[index] &= ~(0xFFFFFFFFul << offset);
-	map[index] |= v << offset;
+	map[index] |= (unsigned long)v << offset;
 }
 
 static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ static inline void xgpio_set_value32(unsigned long *map, int bit, u32 v)`
`99`	`99`	`const unsigned long offset = (bit % BITS_PER_LONG) & BIT(5);`
`100`	`100`
`101`	`101`	`map[index] &= ~(0xFFFFFFFFul << offset);`
`102`		`- map[index] \|= v << offset;`
	`102`	`+ map[index] \|= (unsigned long)v << offset;`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)`