Skip to content

Commit 32fc810

Browse files
Dylan Yudakenaxboe
authored andcommitted
io_uring: do not use prio task_work_add in uring_cmd
io_req_task_prio_work_add has a strict assumption that it will only be used with io_req_task_complete. There is a codepath that assumes this is the case and will not even call the completion function if it is hit. For uring_cmd with an arbitrary completion function change the call to the correct non-priority version. Fixes: ee692a2 ("fs,io_uring: add infrastructure for uring-cmd") Signed-off-by: Dylan Yudaken <dylany@fb.com> Reviewed-by: Pavel Begunkov <asml.silence@gmail.com> Link: https://lore.kernel.org/r/20220616135011.441980-1-dylany@fb.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent a76c0b3 commit 32fc810

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/io_uring.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5017,7 +5017,7 @@ void io_uring_cmd_complete_in_task(struct io_uring_cmd *ioucmd,
50175017

50185018
req->uring_cmd.task_work_cb = task_work_cb;
50195019
req->io_task_work.func = io_uring_cmd_work;
5020-
io_req_task_prio_work_add(req);
5020+
io_req_task_work_add(req);
50215021
}
50225022
EXPORT_SYMBOL_GPL(io_uring_cmd_complete_in_task);
50235023

0 commit comments

Comments
 (0)