NTB: EPF: Fix error code in epf_ntb_bind()

Dan Carpenter · jonmason · commit 3305f43cb6a8 · 2022-08-09T17:54:49.000-04:00
Return an error code if pci_register_driver() fails. Don't return success. Fixes: da51fd2 ("NTB: EPF: support NTB transfer between PCI RC and EP connection") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com> Signed-off-by: Jon Mason <jdmason@kudzu.us>
diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
@@ -1321,7 +1321,8 @@ static int epf_ntb_bind(struct pci_epf *epf)
 	pci_vntb_table[0].vendor = ntb->vntb_vid;
 	pci_vntb_table[0].device = ntb->vntb_pid;
 
-	if (pci_register_driver(&vntb_pci_driver)) {
+	ret = pci_register_driver(&vntb_pci_driver);
+	if (ret) {
 		dev_err(dev, "failure register vntb pci driver\n");
 		goto err_bar_alloc;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1321,7 +1321,8 @@ static int epf_ntb_bind(struct pci_epf *epf)`
`1321`	`1321`	`pci_vntb_table[0].vendor = ntb->vntb_vid;`
`1322`	`1322`	`pci_vntb_table[0].device = ntb->vntb_pid;`
`1323`	`1323`
`1324`		`- if (pci_register_driver(&vntb_pci_driver)) {`
	`1324`	`+ ret = pci_register_driver(&vntb_pci_driver);`
	`1325`	`+ if (ret) {`
`1325`	`1326`	`dev_err(dev, "failure register vntb pci driver\n");`
`1326`	`1327`	`goto err_bar_alloc;`
`1327`	`1328`	`}`