staging: nvec: Use IRQF_NO_AUTOEN flag in request_irq()

ruanjinjie-eng · gregkh · commit 33512ed15745 · 2024-09-13T07:30:23.000+02:00
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> Link: https://lore.kernel.org/r/20240912031731.2211698-1-ruanjinjie@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
@@ -845,13 +845,12 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 		return PTR_ERR(nvec->gpiod);
 	}
 
-	err = devm_request_irq(dev, nvec->irq, nvec_interrupt, 0,
+	err = devm_request_irq(dev, nvec->irq, nvec_interrupt, IRQF_NO_AUTOEN,
 			       "nvec", nvec);
 	if (err) {
 		dev_err(dev, "couldn't request irq\n");
 		return -ENODEV;
 	}
-	disable_irq(nvec->irq);
 
 	tegra_init_i2c_slave(nvec);
 

Original file line number	Diff line number	Diff line change
`@@ -845,13 +845,12 @@ static int tegra_nvec_probe(struct platform_device *pdev)`
`845`	`845`	`return PTR_ERR(nvec->gpiod);`
`846`	`846`	`}`
`847`	`847`
`848`		`- err = devm_request_irq(dev, nvec->irq, nvec_interrupt, 0,`
	`848`	`+ err = devm_request_irq(dev, nvec->irq, nvec_interrupt, IRQF_NO_AUTOEN,`
`849`	`849`	`"nvec", nvec);`
`850`	`850`	`if (err) {`
`851`	`851`	`dev_err(dev, "couldn't request irq\n");`
`852`	`852`	`return -ENODEV;`
`853`	`853`	`}`
`854`		`- disable_irq(nvec->irq);`
`855`	`854`
`856`	`855`	`tegra_init_i2c_slave(nvec);`
`857`	`856`