media: i2c: rdacm21: Fix uninitialized value

Jacopo Mondi · mchehab · commit 33c7ae8f49e3 · 2023-08-14T20:27:58.000+02:00
Fix the following smatch warning: drivers/media/i2c/rdacm21.c:373 ov10640_check_id() error: uninitialized symbol 'val'. Initialize 'val' to 0 in the ov10640_check_id() function. Fixes: 2b82169 ("media: i2c: rdacm21: Power up OV10640 before OV490") Reported-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c
@@ -351,7 +351,7 @@ static void ov10640_power_up(struct rdacm21_device *dev)
 static int ov10640_check_id(struct rdacm21_device *dev)
 {
 	unsigned int i;
-	u8 val;
+	u8 val = 0;
 
 	/* Read OV10640 ID to test communications. */
 	for (i = 0; i < OV10640_PID_TIMEOUT; ++i) {

Original file line number	Diff line number	Diff line change
`@@ -351,7 +351,7 @@ static void ov10640_power_up(struct rdacm21_device *dev)`
`351`	`351`	`static int ov10640_check_id(struct rdacm21_device *dev)`
`352`	`352`	`{`
`353`	`353`	`unsigned int i;`
`354`		`- u8 val;`
	`354`	`+ u8 val = 0;`
`355`	`355`
`356`	`356`	`/* Read OV10640 ID to test communications. */`
`357`	`357`	`for (i = 0; i < OV10640_PID_TIMEOUT; ++i) {`