drm/amd/display: Constify struct timing_generator_funcs

tititiou36 · alexdeucher · commit 347efe5b396c · 2025-05-29T10:57:31.000-04:00
'struct timing_generator_funcs' are not modified in these drivers.

Constifying these structures moves some data to a read-only section, so
increases overall security, especially when the structure holds some
function pointers.

Signed-off-by: Christophe JAILLET &lt;christophe.jaillet@wanadoo.fr&gt;
Reviewed-by: Alex Hung &lt;alex.hung@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c
@@ -502,7 +502,7 @@ void optc2_get_last_used_drr_vtotal(struct timing_generator *optc, uint32_t *ref
 	REG_GET(OTG_DRR_CONTROL, OTG_V_TOTAL_LAST_USED_BY_DRR, refresh_rate);
 }
 
-static struct timing_generator_funcs dcn20_tg_funcs = {
+static const struct timing_generator_funcs dcn20_tg_funcs = {
 		.validate_timing = optc1_validate_timing,
 		.program_timing = optc1_program_timing,
 		.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,
diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn201/dcn201_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn201/dcn201_optc.c
@@ -129,7 +129,7 @@ static void optc201_get_optc_source(struct timing_generator *optc,
 	*num_of_src_opp = 1;
 }
 
-static struct timing_generator_funcs dcn201_tg_funcs = {
+static const struct timing_generator_funcs dcn201_tg_funcs = {
 		.validate_timing = optc201_validate_timing,
 		.program_timing = optc1_program_timing,
 		.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,
diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn30/dcn30_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn30/dcn30_optc.c
@@ -357,7 +357,7 @@ void optc3_tg_init(struct timing_generator *optc)
 	optc1_clear_optc_underflow(optc);
 }
 
-static struct timing_generator_funcs dcn30_tg_funcs = {
+static const struct timing_generator_funcs dcn30_tg_funcs = {
 		.validate_timing = optc1_validate_timing,
 		.program_timing = optc1_program_timing,
 		.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,
diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn301/dcn301_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn301/dcn301_optc.c
@@ -109,7 +109,7 @@ void optc301_setup_manual_trigger(struct timing_generator *optc)
 			OTG_TRIGA_CLEAR, 1);
 }
 
-static struct timing_generator_funcs dcn30_tg_funcs = {
+static const struct timing_generator_funcs dcn30_tg_funcs = {
 		.validate_timing = optc1_validate_timing,
 		.program_timing = optc1_program_timing,
 		.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,
diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn31/dcn31_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn31/dcn31_optc.c
@@ -315,7 +315,7 @@ void optc31_read_otg_state(struct timing_generator *optc,
 	s->otg_double_buffer_control = REG_READ(OTG_DOUBLE_BUFFER_CONTROL);
 }
 
-static struct timing_generator_funcs dcn31_tg_funcs = {
+static const struct timing_generator_funcs dcn31_tg_funcs = {
 		.validate_timing = optc1_validate_timing,
 		.program_timing = optc1_program_timing,
 		.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,
diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn314/dcn314_optc.c
@@ -192,7 +192,7 @@ static void optc314_set_h_timing_div_manual_mode(struct timing_generator *optc,
 }
 
 
-static struct timing_generator_funcs dcn314_tg_funcs = {
+static const struct timing_generator_funcs dcn314_tg_funcs = {
 		.validate_timing = optc1_validate_timing,
 		.program_timing = optc1_program_timing,
 		.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,
diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn32/dcn32_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn32/dcn32_optc.c
@@ -297,7 +297,7 @@ static void optc32_set_drr(
 	optc32_setup_manual_trigger(optc);
 }
 
-static struct timing_generator_funcs dcn32_tg_funcs = {
+static const struct timing_generator_funcs dcn32_tg_funcs = {
 		.validate_timing = optc1_validate_timing,
 		.program_timing = optc1_program_timing,
 		.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,
diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c
@@ -428,7 +428,7 @@ static void optc35_set_long_vtotal(
 	}
 }
 
-static struct timing_generator_funcs dcn35_tg_funcs = {
+static const struct timing_generator_funcs dcn35_tg_funcs = {
 		.validate_timing = optc1_validate_timing,
 		.program_timing = optc1_program_timing,
 		.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,
diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn401/dcn401_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn401/dcn401_optc.c
@@ -459,7 +459,7 @@ bool optc401_wait_update_lock_status(struct timing_generator *tg, bool locked)
 	return true;
 }
 
-static struct timing_generator_funcs dcn401_tg_funcs = {
+static const struct timing_generator_funcs dcn401_tg_funcs = {
 		.validate_timing = optc1_validate_timing,
 		.program_timing = optc1_program_timing,
 		.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,

Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,7 @@ void optc2_get_last_used_drr_vtotal(struct timing_generator optc, uint32_t ref`
`502`	`502`	`REG_GET(OTG_DRR_CONTROL, OTG_V_TOTAL_LAST_USED_BY_DRR, refresh_rate);`
`503`	`503`	`}`
`504`	`504`
`505`		`-static struct timing_generator_funcs dcn20_tg_funcs = {`
	`505`	`+static const struct timing_generator_funcs dcn20_tg_funcs = {`
`506`	`506`	`.validate_timing = optc1_validate_timing,`
`507`	`507`	`.program_timing = optc1_program_timing,`
`508`	`508`	`.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ static void optc201_get_optc_source(struct timing_generator *optc,`
`129`	`129`	`*num_of_src_opp = 1;`
`130`	`130`	`}`
`131`	`131`
`132`		`-static struct timing_generator_funcs dcn201_tg_funcs = {`
	`132`	`+static const struct timing_generator_funcs dcn201_tg_funcs = {`
`133`	`133`	`.validate_timing = optc201_validate_timing,`
`134`	`134`	`.program_timing = optc1_program_timing,`
`135`	`135`	`.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,`
Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ void optc3_tg_init(struct timing_generator *optc)`
`357`	`357`	`optc1_clear_optc_underflow(optc);`
`358`	`358`	`}`
`359`	`359`
`360`		`-static struct timing_generator_funcs dcn30_tg_funcs = {`
	`360`	`+static const struct timing_generator_funcs dcn30_tg_funcs = {`
`361`	`361`	`.validate_timing = optc1_validate_timing,`
`362`	`362`	`.program_timing = optc1_program_timing,`
`363`	`363`	`.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ void optc301_setup_manual_trigger(struct timing_generator *optc)`
`109`	`109`	`OTG_TRIGA_CLEAR, 1);`
`110`	`110`	`}`
`111`	`111`
`112`		`-static struct timing_generator_funcs dcn30_tg_funcs = {`
	`112`	`+static const struct timing_generator_funcs dcn30_tg_funcs = {`
`113`	`113`	`.validate_timing = optc1_validate_timing,`
`114`	`114`	`.program_timing = optc1_program_timing,`
`115`	`115`	`.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,`
Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ void optc31_read_otg_state(struct timing_generator *optc,`
`315`	`315`	`s->otg_double_buffer_control = REG_READ(OTG_DOUBLE_BUFFER_CONTROL);`
`316`	`316`	`}`
`317`	`317`
`318`		`-static struct timing_generator_funcs dcn31_tg_funcs = {`
	`318`	`+static const struct timing_generator_funcs dcn31_tg_funcs = {`
`319`	`319`	`.validate_timing = optc1_validate_timing,`
`320`	`320`	`.program_timing = optc1_program_timing,`
`321`	`321`	`.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,`
Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ static void optc314_set_h_timing_div_manual_mode(struct timing_generator *optc,`
`192`	`192`	`}`
`193`	`193`
`194`	`194`
`195`		`-static struct timing_generator_funcs dcn314_tg_funcs = {`
	`195`	`+static const struct timing_generator_funcs dcn314_tg_funcs = {`
`196`	`196`	`.validate_timing = optc1_validate_timing,`
`197`	`197`	`.program_timing = optc1_program_timing,`
`198`	`198`	`.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,`
Original file line number	Diff line number	Diff line change
`@@ -297,7 +297,7 @@ static void optc32_set_drr(`
`297`	`297`	`optc32_setup_manual_trigger(optc);`
`298`	`298`	`}`
`299`	`299`
`300`		`-static struct timing_generator_funcs dcn32_tg_funcs = {`
	`300`	`+static const struct timing_generator_funcs dcn32_tg_funcs = {`
`301`	`301`	`.validate_timing = optc1_validate_timing,`
`302`	`302`	`.program_timing = optc1_program_timing,`
`303`	`303`	`.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,`
Original file line number	Diff line number	Diff line change
`@@ -428,7 +428,7 @@ static void optc35_set_long_vtotal(`
`428`	`428`	`}`
`429`	`429`	`}`
`430`	`430`
`431`		`-static struct timing_generator_funcs dcn35_tg_funcs = {`
	`431`	`+static const struct timing_generator_funcs dcn35_tg_funcs = {`
`432`	`432`	`.validate_timing = optc1_validate_timing,`
`433`	`433`	`.program_timing = optc1_program_timing,`
`434`	`434`	`.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,`
Original file line number	Diff line number	Diff line change
`@@ -459,7 +459,7 @@ bool optc401_wait_update_lock_status(struct timing_generator *tg, bool locked)`
`459`	`459`	`return true;`
`460`	`460`	`}`
`461`	`461`
`462`		`-static struct timing_generator_funcs dcn401_tg_funcs = {`
	`462`	`+static const struct timing_generator_funcs dcn401_tg_funcs = {`
`463`	`463`	`.validate_timing = optc1_validate_timing,`
`464`	`464`	`.program_timing = optc1_program_timing,`
`465`	`465`	`.setup_vertical_interrupt0 = optc1_setup_vertical_interrupt0,`