Skip to content

Commit 34b4540

Browse files
hfxspamir73il
authored andcommitted
ovl: don't set the superblock's errseq_t manually
Since commit 5679897 ("vfs: make sync_filesystem return errors from ->sync_fs"), the return value from sync_fs callback can be seen in sync_filesystem(). Thus the errseq_set opreation can be removed here. Depends-on: commit 5679897 ("vfs: make sync_filesystem return errors from ->sync_fs") Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com> Reviewed-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
1 parent 3e9bff3 commit 34b4540

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

fs/overlayfs/super.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -202,15 +202,9 @@ static int ovl_sync_fs(struct super_block *sb, int wait)
202202
int ret;
203203

204204
ret = ovl_sync_status(ofs);
205-
/*
206-
* We have to always set the err, because the return value isn't
207-
* checked in syncfs, and instead indirectly return an error via
208-
* the sb's writeback errseq, which VFS inspects after this call.
209-
*/
210-
if (ret < 0) {
211-
errseq_set(&sb->s_wb_err, -EIO);
205+
206+
if (ret < 0)
212207
return -EIO;
213-
}
214208

215209
if (!ret)
216210
return ret;

0 commit comments

Comments
 (0)