tty: hvc: use console_is_registered()

jogness · pmladek · commit 34d9541edef7 · 2022-12-02T11:25:01.000+01:00
It is not reliable to check for CON_ENABLED in order to identify if a console is registered. Use console_is_registered() instead. Signed-off-by: John Ogness <john.ogness@linutronix.de> Reviewed-by: Petr Mladek <pmladek@suse.com> Signed-off-by: Petr Mladek <pmladek@suse.com> Link: https://lore.kernel.org/r/20221116162152.193147-26-john.ogness@linutronix.de
diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
@@ -264,8 +264,8 @@ static void hvc_port_destruct(struct tty_port *port)
 
 static void hvc_check_console(int index)
 {
-	/* Already enabled, bail out */
-	if (hvc_console.flags & CON_ENABLED)
+	/* Already registered, bail out */
+	if (console_is_registered(&hvc_console))
 		return;
 
  	/* If this index is what the user requested, then register

Original file line number	Diff line number	Diff line change
`@@ -264,8 +264,8 @@ static void hvc_port_destruct(struct tty_port *port)`
`264`	`264`
`265`	`265`	`static void hvc_check_console(int index)`
`266`	`266`	`{`
`267`		`- /* Already enabled, bail out */`
`268`		`- if (hvc_console.flags & CON_ENABLED)`
	`267`	`+ /* Already registered, bail out */`
	`268`	`+ if (console_is_registered(&hvc_console))`
`269`	`269`	`return;`
`270`	`270`
`271`	`271`	`/* If this index is what the user requested, then register`