Skip to content

Commit 35597bd

Browse files
ahunter6Ulf Hansson
authored andcommitted
mmc: cqhci: Warn of halt or task clear failure
A correctly operating controller should successfully halt and clear tasks. Failure may result in errors elsewhere, so promote messages from debug to warnings. Fixes: a408022 ("mmc: cqhci: support for command queue enabled host") Cc: stable@vger.kernel.org Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Reviewed-by: Avri Altman <avri.altman@wdc.com> Reviewed-by: Avri Altman <avri.altman@wdc.com> Link: https://lore.kernel.org/r/20231103084720.6886-6-adrian.hunter@intel.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 8155d1f commit 35597bd

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/mmc/host/cqhci-core.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -942,8 +942,8 @@ static bool cqhci_clear_all_tasks(struct mmc_host *mmc, unsigned int timeout)
942942
ret = cqhci_tasks_cleared(cq_host);
943943

944944
if (!ret)
945-
pr_debug("%s: cqhci: Failed to clear tasks\n",
946-
mmc_hostname(mmc));
945+
pr_warn("%s: cqhci: Failed to clear tasks\n",
946+
mmc_hostname(mmc));
947947

948948
return ret;
949949
}
@@ -976,7 +976,7 @@ static bool cqhci_halt(struct mmc_host *mmc, unsigned int timeout)
976976
ret = cqhci_halted(cq_host);
977977

978978
if (!ret)
979-
pr_debug("%s: cqhci: Failed to halt\n", mmc_hostname(mmc));
979+
pr_warn("%s: cqhci: Failed to halt\n", mmc_hostname(mmc));
980980

981981
return ret;
982982
}

0 commit comments

Comments
 (0)