bcachefs: print_string_as_lines: fix extra newline

Kent Overstreet · Kent Overstreet · commit 35a11506a341 · 2025-03-28T12:36:32.000-04:00
Don't print a newline on empty string; this was causing us to also print
an extra newline when we got to the end of th string.

Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/util.c b/fs/bcachefs/util.c
@@ -270,7 +270,7 @@ static void __bch2_print_string_as_lines(const char *prefix, const char *lines,
 		locked = console_trylock();
 	}
 
-	while (1) {
+	while (*lines) {
 		p = strchrnul(lines, '\n');
 		printk("%s%.*s\n", prefix, (int) (p - lines), lines);
 		if (!*p)

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ static void __bch2_print_string_as_lines(const char prefix, const char lines,`
`270`	`270`	`locked = console_trylock();`
`271`	`271`	`}`
`272`	`272`
`273`		`- while (1) {`
	`273`	`+ while (*lines) {`
`274`	`274`	`p = strchrnul(lines, '\n');`
`275`	`275`	`printk("%s%.*s\n", prefix, (int) (p - lines), lines);`
`276`	`276`	`if (!*p)`