Skip to content

Commit 35c8c5e

Browse files
Tharun Kumar Pbroonie
authored andcommitted
spi: mchp-pci1xxxx: Fix length of SPI transactions not set properly in driver
In pci1xxxx_spi_transfer_one API, length of SPI transaction gets cleared by setting of length mask. Set length of transaction only after masking length field. Fixes: 1cc0cbe ("spi: microchip: pci1xxxx: Add driver for SPI controller of PCI1XXXX PCIe switch") Signed-off-by: Tharun Kumar P <tharunkumar.pasumarthi@microchip.com> Link: https://lore.kernel.org/r/20230404171613.1336093-2-tharunkumar.pasumarthi@microchip.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 43bac51 commit 35c8c5e

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/spi/spi-pci1xxxx.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,9 @@ static int pci1xxxx_spi_transfer_one(struct spi_controller *spi_ctlr,
199199
else
200200
regval &= ~SPI_MST_CTL_MODE_SEL;
201201

202-
regval |= ((clkdiv << 5) | SPI_FORCE_CE | (len << 8));
202+
regval |= ((clkdiv << 5) | SPI_FORCE_CE);
203203
regval &= ~SPI_MST_CTL_CMD_LEN_MASK;
204+
regval |= (len << 8);
204205
writel(regval, par->reg_base +
205206
SPI_MST_CTL_REG_OFFSET(p->hw_inst));
206207
regval = readl(par->reg_base +

0 commit comments

Comments
 (0)