Skip to content

Commit 35d6df5

Browse files
azeemshaikh38teigland
authored andcommitted
dlm: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] KSPP#89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Signed-off-by: David Teigland <teigland@redhat.com>
1 parent 44c026a commit 35d6df5

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

fs/dlm/config.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,9 @@ static ssize_t cluster_cluster_name_store(struct config_item *item,
116116
{
117117
struct dlm_cluster *cl = config_item_to_cluster(item);
118118

119-
strlcpy(dlm_config.ci_cluster_name, buf,
119+
strscpy(dlm_config.ci_cluster_name, buf,
120120
sizeof(dlm_config.ci_cluster_name));
121-
strlcpy(cl->cl_cluster_name, buf, sizeof(cl->cl_cluster_name));
121+
strscpy(cl->cl_cluster_name, buf, sizeof(cl->cl_cluster_name));
122122
return len;
123123
}
124124

0 commit comments

Comments
 (0)