Skip to content

Commit 360bd6c

Browse files
committed
parisc: Use constants to encode the space registers like SR_KERNEL
Use the provided space register constants instead of hardcoded values. Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 5613a93 commit 360bd6c

7 files changed

Lines changed: 24 additions & 27 deletions

File tree

arch/parisc/include/asm/cache.h

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,13 @@ extern int icache_stride;
3939
extern struct pdc_cache_info cache_info;
4040
void parisc_setup_cache_timing(void);
4141

42-
#define pdtlb(addr) asm volatile("pdtlb 0(%%sr1,%0)" \
42+
#define pdtlb(sr, addr) asm volatile("pdtlb 0(%%sr%0,%1)" \
4343
ALTERNATIVE(ALT_COND_NO_SMP, INSN_PxTLB) \
44-
: : "r" (addr) : "memory")
45-
#define pitlb(addr) asm volatile("pitlb 0(%%sr1,%0)" \
44+
: : "i"(sr), "r" (addr) : "memory")
45+
#define pitlb(sr, addr) asm volatile("pitlb 0(%%sr%0,%1)" \
4646
ALTERNATIVE(ALT_COND_NO_SMP, INSN_PxTLB) \
4747
ALTERNATIVE(ALT_COND_NO_SPLIT_TLB, INSN_NOP) \
48-
: : "r" (addr) : "memory")
49-
#define pdtlb_kernel(addr) asm volatile("pdtlb 0(%0)" \
50-
ALTERNATIVE(ALT_COND_NO_SMP, INSN_PxTLB) \
51-
: : "r" (addr) : "memory")
48+
: : "i"(sr), "r" (addr) : "memory")
5249

5350
#define asm_io_fdc(addr) asm volatile("fdc %%r0(%0)" \
5451
ALTERNATIVE(ALT_COND_NO_DCACHE, INSN_NOP) \

arch/parisc/include/asm/mmu_context.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ static inline unsigned long __space_to_prot(mm_context_t context)
4343

4444
static inline void load_context(mm_context_t context)
4545
{
46-
mtsp(context.space_id, 3);
46+
mtsp(context.space_id, SR_USER);
4747
mtctl(__space_to_prot(context), 8);
4848
}
4949

arch/parisc/include/asm/pgtable.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ static inline void purge_tlb_entries(struct mm_struct *mm, unsigned long addr)
7070
unsigned long flags;
7171

7272
purge_tlb_start(flags);
73-
mtsp(mm->context.space_id, 1);
74-
pdtlb(addr);
75-
pitlb(addr);
73+
mtsp(mm->context.space_id, SR_TEMP1);
74+
pdtlb(SR_TEMP1, addr);
75+
pitlb(SR_TEMP1, addr);
7676
purge_tlb_end(flags);
7777
}
7878

arch/parisc/include/asm/special_insns.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ static inline void set_eiem(unsigned long val)
5555
#define mfsp(reg) ({ \
5656
unsigned long cr; \
5757
__asm__ __volatile__( \
58-
"mfsp " #reg ",%0" : \
59-
"=r" (cr) \
58+
"mfsp %%sr%1,%0" \
59+
: "=r" (cr) : "i"(reg) \
6060
); \
6161
cr; \
6262
})

arch/parisc/kernel/cache.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ void flush_kernel_dcache_page_addr(void *addr)
457457

458458
flush_kernel_dcache_page_asm(addr);
459459
purge_tlb_start(flags);
460-
pdtlb_kernel(addr);
460+
pdtlb(SR_KERNEL, addr);
461461
purge_tlb_end(flags);
462462
}
463463
EXPORT_SYMBOL(flush_kernel_dcache_page_addr);
@@ -496,9 +496,9 @@ int __flush_tlb_range(unsigned long sid, unsigned long start,
496496
but cause a purge request to be broadcast to other TLBs. */
497497
while (start < end) {
498498
purge_tlb_start(flags);
499-
mtsp(sid, 1);
500-
pdtlb(start);
501-
pitlb(start);
499+
mtsp(sid, SR_TEMP1);
500+
pdtlb(SR_TEMP1, start);
501+
pitlb(SR_TEMP1, start);
502502
purge_tlb_end(flags);
503503
start += PAGE_SIZE;
504504
}

arch/parisc/kernel/pci-dma.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ static inline int map_pte_uncached(pte_t * pte,
9191
printk(KERN_ERR "map_pte_uncached: page already exists\n");
9292
purge_tlb_start(flags);
9393
set_pte(pte, __mk_pte(*paddr_ptr, PAGE_KERNEL_UNC));
94-
pdtlb_kernel(orig_vaddr);
94+
pdtlb(SR_KERNEL, orig_vaddr);
9595
purge_tlb_end(flags);
9696
vaddr += PAGE_SIZE;
9797
orig_vaddr += PAGE_SIZE;
@@ -175,7 +175,7 @@ static inline void unmap_uncached_pte(pmd_t * pmd, unsigned long vaddr,
175175

176176
pte_clear(&init_mm, vaddr, pte);
177177
purge_tlb_start(flags);
178-
pdtlb_kernel(orig_vaddr);
178+
pdtlb(SR_KERNEL, orig_vaddr);
179179
purge_tlb_end(flags);
180180
vaddr += PAGE_SIZE;
181181
orig_vaddr += PAGE_SIZE;

arch/parisc/lib/memcpy.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
#include <linux/compiler.h>
1414
#include <linux/uaccess.h>
1515

16-
#define get_user_space() (uaccess_kernel() ? 0 : mfsp(3))
17-
#define get_kernel_space() (0)
16+
#define get_user_space() mfsp(SR_USER)
17+
#define get_kernel_space() SR_KERNEL
1818

1919
/* Returns 0 for success, otherwise, returns number of bytes not transferred. */
2020
extern unsigned long pa_memcpy(void *dst, const void *src,
@@ -23,25 +23,25 @@ extern unsigned long pa_memcpy(void *dst, const void *src,
2323
unsigned long raw_copy_to_user(void __user *dst, const void *src,
2424
unsigned long len)
2525
{
26-
mtsp(get_kernel_space(), 1);
27-
mtsp(get_user_space(), 2);
26+
mtsp(get_kernel_space(), SR_TEMP1);
27+
mtsp(get_user_space(), SR_TEMP2);
2828
return pa_memcpy((void __force *)dst, src, len);
2929
}
3030
EXPORT_SYMBOL(raw_copy_to_user);
3131

3232
unsigned long raw_copy_from_user(void *dst, const void __user *src,
3333
unsigned long len)
3434
{
35-
mtsp(get_user_space(), 1);
36-
mtsp(get_kernel_space(), 2);
35+
mtsp(get_user_space(), SR_TEMP1);
36+
mtsp(get_kernel_space(), SR_TEMP2);
3737
return pa_memcpy(dst, (void __force *)src, len);
3838
}
3939
EXPORT_SYMBOL(raw_copy_from_user);
4040

4141
void * memcpy(void * dst,const void *src, size_t count)
4242
{
43-
mtsp(get_kernel_space(), 1);
44-
mtsp(get_kernel_space(), 2);
43+
mtsp(get_kernel_space(), SR_TEMP1);
44+
mtsp(get_kernel_space(), SR_TEMP2);
4545
pa_memcpy(dst, src, count);
4646
return dst;
4747
}

0 commit comments

Comments
 (0)