Skip to content

Commit 366ca0b

Browse files
Ayushi Makhijalumag
authored andcommitted
drm/bridge: anx7625: fix anx7625_sink_detect() to return correct hpd status
In the anx7625_sink_detect(), the device is checked to see if it is a panel bridge, and it always sends a "connected" status to the connector. When adding the DP port on port 1 of the anx7625, it incorrectly treats it as a panel bridge and sends an always "connected" status. Instead of checking the status on the panel bridge, it's better to check the hpd_status for connectors that supports hot-plugging. This way, it verifies the hpd_status variable before sending the status to the connector. In case of eDP, anx7625_bridge_detect() will not get called because the bridge->ops condition in anx7625_link_bridge() will not be satisfied. Since anx7625_sink_detect() is called from anx7625_bridge_detect(), this results in the sink_detect logic not being executed for eDP. Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Link: https://lore.kernel.org/r/20250505094245.2660750-6-quic_amakhija@quicinc.com Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
1 parent 71867e8 commit 366ca0b

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

drivers/gpu/drm/bridge/analogix/anx7625.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1814,9 +1814,6 @@ static enum drm_connector_status anx7625_sink_detect(struct anx7625_data *ctx)
18141814

18151815
DRM_DEV_DEBUG_DRIVER(dev, "sink detect\n");
18161816

1817-
if (ctx->pdata.panel_bridge)
1818-
return connector_status_connected;
1819-
18201817
return ctx->hpd_status ? connector_status_connected :
18211818
connector_status_disconnected;
18221819
}

0 commit comments

Comments
 (0)