Skip to content

Commit 37004db

Browse files
Len Bakerbebarino
authored andcommitted
clk: ti: composite: Prefer kcalloc over open coded arithmetic
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors. So, use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function. [1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments Signed-off-by: Len Baker <len.baker@gmx.com> Link: https://lore.kernel.org/r/20210904131714.2312-1-len.baker@gmx.com Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent bae71de commit 37004db

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/clk/ti/composite.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ int __init ti_clk_add_component(struct device_node *node, struct clk_hw *hw,
255255
return -EINVAL;
256256
}
257257

258-
parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL);
258+
parent_names = kcalloc(num_parents, sizeof(char *), GFP_KERNEL);
259259
if (!parent_names)
260260
return -ENOMEM;
261261

0 commit comments

Comments
 (0)